From: Boqun Feng <boqun.feng@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mike Galbraith <efault@gmx.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] locking: rwbase: Take care of ordering guarantee for fastpath reader
Date: Wed, 8 Sep 2021 21:00:22 +0800 [thread overview]
Message-ID: <YTiz5i3Kxuhv4w4X@boqun-archlinux> (raw)
In-Reply-To: <YTipJJcjU57l7Mju@hirez.programming.kicks-ass.net>
On Wed, Sep 08, 2021 at 02:14:28PM +0200, Peter Zijlstra wrote:
> On Wed, Sep 08, 2021 at 01:51:24PM +0200, Peter Zijlstra wrote:
> > On Wed, Sep 01, 2021 at 11:06:27PM +0800, Boqun Feng wrote:
> > @@ -201,23 +207,30 @@ static int __sched rwbase_write_lock(struct rwbase_rt *rwb,
> > {
> > struct rt_mutex_base *rtm = &rwb->rtmutex;
> > unsigned long flags;
> > + int readers;
> >
> > /* Take the rtmutex as a first step */
> > if (rwbase_rtmutex_lock_state(rtm, state))
> > return -EINTR;
> >
> > /* Force readers into slow path */
> > - atomic_sub(READER_BIAS, &rwb->readers);
> > + readers = atomic_sub_return_relaxed(READER_BIAS, &rwb->readers);
>
> Hurmph... the above really begs for something like
>
> if (!readers)
> return 0;
>
I don't think we can return early here, don't we need to set WRITER_BIAS
to grab the write lock? And we can only do that with ->wait_lock held,
otherwise we race with the slowpath of readers.
Regards,
Boqun
> But then we needs that _acquire() thing again :/
>
next prev parent reply other threads:[~2021-09-08 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 15:06 Boqun Feng
2021-09-01 18:53 ` Waiman Long
2021-09-01 20:22 ` Davidlohr Bueso
2021-09-02 5:02 ` Boqun Feng
2021-09-02 11:55 ` Peter Zijlstra
2021-09-03 14:50 ` Boqun Feng
2021-09-04 10:12 ` Peter Zijlstra
2021-09-04 10:14 ` Peter Zijlstra
2021-09-04 10:19 ` Boqun Feng
2021-09-08 11:51 ` Peter Zijlstra
2021-09-08 12:14 ` Peter Zijlstra
2021-09-08 13:00 ` Boqun Feng [this message]
2021-09-08 13:08 ` Boqun Feng
2021-09-08 14:41 ` Peter Zijlstra
2021-09-08 14:49 ` Peter Zijlstra
2021-09-08 18:34 ` Davidlohr Bueso
2021-09-08 13:27 ` Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTiz5i3Kxuhv4w4X@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=dave@stgolabs.net \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--subject='Re: [RFC] locking: rwbase: Take care of ordering guarantee for fastpath reader' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).