From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 697C7C4332F for ; Wed, 8 Sep 2021 15:30:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E59C610C8 for ; Wed, 8 Sep 2021 15:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352083AbhIHPbH (ORCPT ); Wed, 8 Sep 2021 11:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352040AbhIHPbG (ORCPT ); Wed, 8 Sep 2021 11:31:06 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E15AC061757 for ; Wed, 8 Sep 2021 08:29:59 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id s11so2975038pgr.11 for ; Wed, 08 Sep 2021 08:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BdySeMpA5oxLZqf0kkPZHfESZokTOyR4F7+QPgrkdO4=; b=X/hiE8lRT8yZAgqubh4mszFmc1kMRhqDJkXKT6BTT9PYPwkuTvUrHscMOW8YkAdMQq FjV2kcCziH0PjL2i2EfuI2AatrsP2M9xRCIjEClmVBJKS8lIiKs+qwp9yWRu+ej5eTBy +/f3jo1R5MfTUn2rk4kz4Jec2oM3otoQ29ck0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BdySeMpA5oxLZqf0kkPZHfESZokTOyR4F7+QPgrkdO4=; b=1TQaXcmzbs9PDPiGUdhhLG/QSIf+kx6hFWkLMIaQSqrC4ljLNRa76wU5Bq4gFHRDdq 06pAObPxdNq1TffMzTArGM/QqqaIneu0gOKJ4K3A4ytjdud4YKknIt41cAJ/GCFkgNy4 ijyf1FQjouUdY7GegKI4Vt5dRxjwZrGrwjdNDAEyCfWa/s05t7wdnKdLXZpB3nahM64x SPt0Oj0vmkZTpTWLFirOBVMpkVazNBT6Sa+WgNN+oOh8HVJ0JFpYI0QzdBzUTh9EKmuX YRl2TdTqIwYtvoqrPneNb8KlHI8TjkJ+kDpJEW/tBy7XkWGJpqEuFNg6qq+uDqEq6NlE YiRg== X-Gm-Message-State: AOAM5325SaWafckLcS0FCh2xAFvWrA00oLh1nq7p3ZTwEGQ8t+/YMF38 21U3jRVFAadFu+tpAn34Qriftg== X-Google-Smtp-Source: ABdhPJxP+IqKzKFKsz+xkh8ZRWYjhvOy/HgDupCGDDUOuHyv85z/btvLyACH7BUGQ82dUNy1yf5juw== X-Received: by 2002:a63:e516:: with SMTP id r22mr4275826pgh.197.1631114998456; Wed, 08 Sep 2021 08:29:58 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c6b2:7ae:474d:36f6]) by smtp.gmail.com with UTF8SMTPSA id a20sm2504035pjh.46.2021.09.08.08.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 08:29:58 -0700 (PDT) Date: Wed, 8 Sep 2021 08:29:56 -0700 From: Matthias Kaehlcke To: skakit@codeaurora.org Cc: Pavel Machek , Rob Herring , Andy Gross , Bjorn Andersson , swboyd@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support Message-ID: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 08, 2021 at 02:37:39PM +0530, skakit@codeaurora.org wrote: > On 2021-09-07 23:46, Matthias Kaehlcke wrote: > > On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote: > > > Add pwm support for PM8350C pmic. > > > > > > Signed-off-by: satya priya > > > --- > > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > index e1b75ae..ecdae55 100644 > > > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > @@ -29,6 +29,12 @@ > > > interrupt-controller; > > > #interrupt-cells = <2>; > > > }; > > > + > > > + pm8350c_pwm4: pwm { > > > > What does the '4' represent, an internal channel number? It should > > probably be omitted if the PM8350 only has a single output PWM > > port. > > > > pm8350c has four PWMs, but I think we can drop the '4' here. Why is only one PWM exposed if the PMIC has for of them? Why number 4 and not one of the others?