From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22427C4332F for ; Wed, 8 Sep 2021 17:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 050B661157 for ; Wed, 8 Sep 2021 17:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352399AbhIHRIx (ORCPT ); Wed, 8 Sep 2021 13:08:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352337AbhIHRIw (ORCPT ); Wed, 8 Sep 2021 13:08:52 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63B17C061575 for ; Wed, 8 Sep 2021 10:07:44 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id n27so4027828oij.0 for ; Wed, 08 Sep 2021 10:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E4tOgOt4yehd+aPYxD2GXw5G5+5COCK1/J0EptH+YuM=; b=Lht57q8kyiusHO0ElOuT7VBKg0czz5rVv5T1bwBy1eW+n36Goac9gNjuGKDhChI4YJ RPStEbU3JJZyI9dlyEj6Gux9JD6JN+eVM9NorAt/IYbkqldVFrg8QCm/Hy3xuoD+azpW fplHX1drC2ZWwHDISq4dmbnpo5txAGI9d4RmjbYN8XZD78JFPdmCg/FDQBoGJ0C/kdae 2lTFQKTBWnR0eSqHd4yn2ENxhHvyv0t3Fw9ic103ZEWsSn7WvhT858fodmzp7SQfrdel IqoTvSfxrYkFVVhZmSdV2ZYSATA1qIIuFzuCrFVy5rLDENRwgR9eDTVXUKyXTkk2wpeJ lOMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E4tOgOt4yehd+aPYxD2GXw5G5+5COCK1/J0EptH+YuM=; b=R5h1rRvvBVr0LUATdtiJ6hTwOlB952V/ujkjFjdl7pOvZm6wtE5DwlkIslVll46aj5 L2sNv62OHtKjSJu/NdfgaC6eXFqM0Dv1+IlrjtCHXBx3pJpTnrrDth21qijLWjX/8EPh 2ky++idqJ/pVW1rgGVf2tCH9+xSY/Sb/lzx2ZlM4UtzHSzhs8Ab8OedI6q/wpRq7Ftw/ 8uNaKsDqAElirY5DS+odQomwF/HacFidLWeuSWzmOodpbtg5aU6sAnWCt1DhEoyJy92p KMGqeP9zrvCMo3Mr/HLeg+PZ3KygN/e+Bj6GPSfnT08ZoBzuMc74cRlYUyBANTRZJQsx YXyQ== X-Gm-Message-State: AOAM532W0oM/eu4jI/LYlnwtfqfV2wdLyusi6dXrcL6+isQI8cfeLfgC G65JXM+0t7oXKBB+Q5Au83K/Hg== X-Google-Smtp-Source: ABdhPJxbfp3uV4sVKN/yboHL2W/8Wr9ZjBACTTJiR6MFAPHCagAUyXDvUVboRobIZ68QRCxTKhTaEA== X-Received: by 2002:aca:3b85:: with SMTP id i127mr3157888oia.28.1631120863614; Wed, 08 Sep 2021 10:07:43 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h17sm544947otl.74.2021.09.08.10.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 10:07:43 -0700 (PDT) Date: Wed, 8 Sep 2021 10:08:41 -0700 From: Bjorn Andersson To: Matthias Kaehlcke Cc: skakit@codeaurora.org, Pavel Machek , Rob Herring , Andy Gross , swboyd@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support Message-ID: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08 Sep 08:29 PDT 2021, Matthias Kaehlcke wrote: > On Wed, Sep 08, 2021 at 02:37:39PM +0530, skakit@codeaurora.org wrote: > > On 2021-09-07 23:46, Matthias Kaehlcke wrote: > > > On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote: > > > > Add pwm support for PM8350C pmic. > > > > > > > > Signed-off-by: satya priya > > > > --- > > > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > > b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > > index e1b75ae..ecdae55 100644 > > > > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > > > > @@ -29,6 +29,12 @@ > > > > interrupt-controller; > > > > #interrupt-cells = <2>; > > > > }; > > > > + > > > > + pm8350c_pwm4: pwm { > > > > > > What does the '4' represent, an internal channel number? It should > > > probably be omitted if the PM8350 only has a single output PWM > > > port. > > > > > > > pm8350c has four PWMs, but I think we can drop the '4' here. > > Why is only one PWM exposed if the PMIC has for of them? Why number 4 > and not one of the others? The node should represent all 4 channels, which ones the board uses is captured in how they are bound to other clients - or defines as LEDs by additional child nodes. Regards, Bjorn