From: Greg KH <gregkh@linuxfoundation.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
syzbot <syzbot+ce96ca2b1d0b37c6422d@syzkaller.appspotmail.com>,
coreteam@netfilter.org, davem@davemloft.net, fw@strlen.de,
kadlec@netfilter.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
stable@vger.kernel.org, elbrus@debian.org
Subject: Re: [syzbot] general protection fault in nft_set_elem_expr_alloc
Date: Thu, 9 Sep 2021 08:20:22 +0200 [thread overview]
Message-ID: <YTmnpquHt3+02t9k@kroah.com> (raw)
In-Reply-To: <YTkj4xH2Ol075+Ge@eldamar.lan>
On Wed, Sep 08, 2021 at 10:58:11PM +0200, Salvatore Bonaccorso wrote:
> Hi Pablo,
>
> On Wed, Jun 02, 2021 at 07:03:17PM +0200, Pablo Neira Ayuso wrote:
> > On Wed, Jun 02, 2021 at 09:37:26AM -0700, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit: 6850ec97 Merge branch 'mptcp-fixes-for-5-13'
> > > git tree: net
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=1355504dd00000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=770708ea7cfd4916
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=ce96ca2b1d0b37c6422d
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1502d517d00000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12bbbe13d00000
> > >
> > > The issue was bisected to:
> > >
> > > commit 05abe4456fa376040f6cc3cc6830d2e328723478
> > > Author: Pablo Neira Ayuso <pablo@netfilter.org>
> > > Date: Wed May 20 13:44:37 2020 +0000
> > >
> > > netfilter: nf_tables: allow to register flowtable with no devices
> > >
> > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=10fa1387d00000
> > > final oops: https://syzkaller.appspot.com/x/report.txt?x=12fa1387d00000
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14fa1387d00000
> > >
> > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > Reported-by: syzbot+ce96ca2b1d0b37c6422d@syzkaller.appspotmail.com
> > > Fixes: 05abe4456fa3 ("netfilter: nf_tables: allow to register flowtable with no devices")
> > >
> > > general protection fault, probably for non-canonical address 0xdffffc000000000e: 0000 [#1] PREEMPT SMP KASAN
> > > KASAN: null-ptr-deref in range [0x0000000000000070-0x0000000000000077]
> > > CPU: 1 PID: 8438 Comm: syz-executor343 Not tainted 5.13.0-rc3-syzkaller #0
> > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> > > RIP: 0010:nft_set_elem_expr_alloc+0x17e/0x280 net/netfilter/nf_tables_api.c:5321
> > > Code: 48 c1 ea 03 80 3c 02 00 0f 85 09 01 00 00 49 8b 9d c0 00 00 00 48 b8 00 00 00 00 00 fc ff df 48 8d 7b 70 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 d9 00 00 00 48 8b 5b 70 48 85 db 74 21 e8 9a bd
> >
> > It's a real bug. Bisect is not correct though.
> >
> > I'll post a patch to fix it. Thanks.
>
> So if I see it correctly the fix landed in ad9f151e560b ("netfilter:
> nf_tables: initialize set before expression setup") in 5.13-rc7 and
> landed as well in 5.12.13. The issue is though still present in the
> 5.10.y series.
>
> Would it be possible to backport the fix as well to 5.10.y? It is
> needed there as well.
I would need a working backport, as it does not apply cleanly to 5.10.y
:(
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-09 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 16:37 [syzbot] general protection fault in nft_set_elem_expr_alloc syzbot
2021-06-02 17:03 ` Pablo Neira Ayuso
2021-09-08 20:58 ` Salvatore Bonaccorso
2021-09-09 6:20 ` Greg KH [this message]
2021-09-09 14:05 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTmnpquHt3+02t9k@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=carnil@debian.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=elbrus@debian.org \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+ce96ca2b1d0b37c6422d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).