From: Greg KH <gregkh@linuxfoundation.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx,
nathan@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: r8188eu: os_dep: simplifiy the rtw_resume function
Date: Thu, 9 Sep 2021 12:03:52 +0200 [thread overview]
Message-ID: <YTncCDuVwnk9RF09@kroah.com> (raw)
In-Reply-To: <41bd374e-3122-0580-f38d-bb03401730b6@gmail.com>
On Wed, Sep 08, 2021 at 11:17:20PM +0530, Saurav Girepunje wrote:
>
>
> On 05/09/21 8:18 pm, Greg KH wrote:
> > On Sat, Sep 04, 2021 at 05:44:44PM +0530, Saurav Girepunje wrote:
> > > Remove unused variable ret and pwrpriv.
> > > Remove the condition with no effect (if == else) in usb_intf.c
> > > file.
> > > Remove rtw_resume_process() and move whole thing to rtw_resume().
> > >
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > >
> > > ChangeLog V2:
> > > - Remove rtw_resume_process() and move whole thing to rtw_resume().
> > > ---
> > > drivers/staging/r8188eu/include/usb_osintf.h | 2 --
> > > drivers/staging/r8188eu/os_dep/usb_intf.c | 12 ------------
> > > 2 files changed, 14 deletions(-)
> > >
> > > diff --git a/drivers/staging/r8188eu/include/usb_osintf.h b/drivers/staging/r8188eu/include/usb_osintf.h
> > > index d1a1f739309c..34229b1cb081 100644
> > > --- a/drivers/staging/r8188eu/include/usb_osintf.h
> > > +++ b/drivers/staging/r8188eu/include/usb_osintf.h
> > > @@ -24,6 +24,4 @@ void *scdb_findEntry(struct adapter *priv, unsigned char *macAddr,
> > > void nat25_db_expire(struct adapter *priv);
> > > int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method);
> > >
> > > -int rtw_resume_process(struct adapter *padapter);
> > > -
> > > #endif
> > > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > > index bb85ab77fd26..77b03e7631b7 100644
> > > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > > @@ -493,18 +493,6 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> > > {
> > > struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
> > > struct adapter *padapter = dvobj->if1;
> > > - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> > > - int ret = 0;
> > > -
> > > - if (pwrpriv->bInternalAutoSuspend)
> > > - ret = rtw_resume_process(padapter);
> > > - else
> > > - ret = rtw_resume_process(padapter);
> > > - return ret;
> > > -}
> > > -
> > > -int rtw_resume_process(struct adapter *padapter)
> > > -{
> > > struct net_device *pnetdev;
> > > struct pwrctrl_priv *pwrpriv = NULL;
> > > int ret = -1;
> >
> > You can also remove the test for padapter being NULL in this function,
> > as you just proved it could never be null otherwise the above function
> > you removed would have crashed, right? You should do that all at once
> > so we remember why that test was removed.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Yes, padapter was deference without checking it could be NULL on rtw_resume.
How can it ever be NULL there?
> I think having NULL check would be safe. However if padapter is NULL then on
> goto exit "if (pwrpriv)" condition will never true as pwrpriv is
> initialized with NULL. There should be one more goto exit just to return.!
>
> let me know you thought greg,
Don't check for things that can never happen.
thanks,
greg k-h
prev parent reply other threads:[~2021-09-09 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 12:14 [PATCH v2] staging: r8188eu: os_dep: simplifiy the rtw_resume function Saurav Girepunje
2021-09-05 14:48 ` Greg KH
2021-09-08 17:47 ` Saurav Girepunje
2021-09-09 10:03 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTncCDuVwnk9RF09@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=nathan@kernel.org \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).