From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Denis Pauk <pauk.denis@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] hwmon: (nct6775) Use superio function pointers (v2)
Date: Thu, 9 Sep 2021 19:53:58 +0300 [thread overview]
Message-ID: <YTo8JnOAaF5W/Mr5@smile.fi.intel.com> (raw)
In-Reply-To: <20210908213605.9929-2-pauk.denis@gmail.com>
On Thu, Sep 09, 2021 at 12:36:03AM +0300, Denis Pauk wrote:
> Use superio function pointers in nct6775_sio_data instead direct calls.
>
> v2: split changes to separate patches
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
Similar comments as per patch 1.
...
> + void (*outb)(struct nct6775_sio_data *sio_data, int reg, int val);
> + int (*inb)(struct nct6775_sio_data *sio_data, int reg);
This part should be split separately and actually be a part of patch 1.
...
> -static inline void
> +static void
> superio_outb(struct nct6775_sio_data *sio_data, int reg, int val)
I guess it's one line and it should be a part of patch 1.
...
> -static inline int
> +static int
> superio_inb(struct nct6775_sio_data *sio_data, int reg)
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-09-09 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <08262b12-4345-76a9-87be-66d630af3a59@roeck-us.net>
2021-09-08 21:36 ` [PATCH 1/3] hwmon: (nct6775) Use sio_data in superio_* (v2) Denis Pauk
2021-09-08 21:36 ` [PATCH 2/3] hwmon: (nct6775) Use superio function pointers (v2) Denis Pauk
2021-09-09 16:53 ` Andy Shevchenko [this message]
2021-09-08 21:36 ` [PATCH 3/3] hwmon: (nct6775) Support access via Asus WMI (v2) Denis Pauk
2021-09-09 17:00 ` Guenter Roeck
2021-09-09 17:01 ` Andy Shevchenko
2021-09-09 16:50 ` [PATCH 1/3] hwmon: (nct6775) Use sio_data in superio_* (v2) Andy Shevchenko
2021-09-11 22:24 ` Denis Pauk
2021-09-12 14:43 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTo8JnOAaF5W/Mr5@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pauk.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).