From: "Michal Koutný" <mkoutny@suse.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: brookxu <brookxu.cn@gmail.com>,
tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Thu, 9 Sep 2021 20:56:16 +0200 [thread overview]
Message-ID: <YTpY0G3+IJYmGbdd@blackbook> (raw)
In-Reply-To: <CAHVum0ffLr+MsF0O+yEWKcdpR0J0TQx6GdDxeZFZY7utZT8=KA@mail.gmail.com>
On Thu, Sep 09, 2021 at 09:49:56AM -0700, Vipin Sharma <vipinsh@google.com> wrote:
> We are adding two files in this patch series, misc.events and
> misc.events.local. I think "fail" should go in misc.events.local and
> its name should be changed to "max".
I consider the max vs fail orthogonal to local vs hierarchical. I.e.
both entries can be in both files:
(1) misc.events.local:max number of times the cgroup's misc.max was hit
(2) misc.events.local:fail number of times operation failed in the cgroup
(3) misc.events:max number of times the cgroup's misc.max was hit in the subtree
(4) misc.events:fail number of times operation failed in the subtree
Is that too many? Admittedly, I assume (1) and (4) will be the more useful ones.
However, I'm afraid overloading "max" as suggested might be (more)
confusing. ('subtree' above := self or descendant)
Michal
next prev parent reply other threads:[~2021-09-09 18:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:24 [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local brookxu
2021-09-08 5:24 ` [RFC PATCH 2/3] misc_cgroup: introduce misc.failcnt for V1 brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-08 5:24 ` [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-09 16:49 ` Vipin Sharma
2021-09-09 18:56 ` Michal Koutný [this message]
2021-09-10 5:30 ` brookxu
2021-09-10 9:23 ` Michal Koutný
2021-09-10 14:29 ` brookxu.cn
2021-09-10 15:36 ` Michal Koutný
2021-09-10 16:29 ` Tejun Heo
2021-09-10 17:16 ` Vipin Sharma
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:31 ` Vipin Sharma
2021-09-10 17:37 ` Tejun Heo
2021-09-09 14:37 ` [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local Michal Koutný
2021-09-09 17:08 ` Vipin Sharma
2021-09-10 5:20 ` brookxu
2021-09-10 10:33 ` Michal Koutný
2021-09-10 16:32 ` Tejun Heo
2021-09-09 16:56 ` Vipin Sharma
2021-09-10 5:21 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTpY0G3+IJYmGbdd@blackbook \
--to=mkoutny@suse.com \
--cc=brookxu.cn@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).