From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872D4C433F5 for ; Thu, 9 Sep 2021 20:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69D266113A for ; Thu, 9 Sep 2021 20:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345296AbhIIUit (ORCPT ); Thu, 9 Sep 2021 16:38:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35280 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245195AbhIIUis (ORCPT ); Thu, 9 Sep 2021 16:38:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=mM50TrfQqQvdPGgFlZnAt32dDbSDk7TXR1qkzbZPrRI=; b=cO M4N/paCpnShAZbECOOAcisClegFIIIrUT7K0atK3lxh4SBwKqpJiURyIl0yI68ennqVQC1qT7OEQm yeHd42Rab44gCIf2Penp6PjuTqTEJheV/QLZGugT+qK0uv0bda8XANPmj0Eg6Qf7CWBozlJO8QvjN V0f/GfvTXanYrY4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mOQnd-005xdu-5o; Thu, 09 Sep 2021 22:37:33 +0200 Date: Thu, 9 Sep 2021 22:37:33 +0200 From: Andrew Lunn To: "Modi, Geet" Cc: "Nagalla, Hari" , "davem@davemloft.net" , "kuba@kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Sharma, Vikram" Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83tc811: modify list of interrupts enabled at initialization Message-ID: References: <20210902190944.4963-1-hnagalla@ti.com> <99232B33-1C2F-45AF-A259-0868AC7D3FBC@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I am planning to have following commit msg; > > > > “This feature is not used by our mainstream customers as they have additional As i said, this is not your driver, for you customers. It is the Linux kernel driver. Please drop all references to your customers. If you need to address anybody, it should be the Linux community as a whole, or maybe the users of this driver. > mechanism to monitor the supply at System level as accuracy requirements are > different for each application. The device is designed with inbuilt monitor > with interrupt disabled by default and let user choose if they want to exercise > the monitor. However, the driver had this interrupt enabled, the request here > is disable it by default in driver however not change in datasheet. Let user > of the driver review the accuracy offered by monitor and if meets the > expectation, they can always enable it.” I would much more prefer something like... The over voltage interrupt is enabled, but if it every occurs, there is no code to make use of it. So remove the pointless enabling of it. It can re-enabled when HWMON support is added. For the same reason, enabling of the interrupts DP83811_RX_ERR_HF_INT_EN, DP83811_MS_TRAINING_INT_EN, DP83811_ESD_EVENT_INT_EN, DP83811_ENERGY_DET_INT_EN, DP83811_LINK_QUAL_INT_EN, DP83811_JABBER_DET_INT_EN, DP83811_POLARITY_INT_EN, DP83811_SLEEP_MODE_INT_EN, DP83811_OVERTEMP_INT_EN, DP83811_UNDERVOLTAGE_INT_EN is also removed, since there is no code which acts on these interrupts. And update the patch to fit. Andrew