From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Andre Muller <andre.muller@web.de>,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: property: Disable fw_devlink DT support for X86
Date: Fri, 10 Sep 2021 08:15:37 +0200 [thread overview]
Message-ID: <YTr4CZW+rOXAjNq9@kroah.com> (raw)
In-Reply-To: <20210910011446.3208894-1-saravanak@google.com>
On Thu, Sep 09, 2021 at 06:14:45PM -0700, Saravana Kannan wrote:
> Andre reported fw_devlink=on breaking OLPC XO-1.5 [1].
>
> OLPC XO-1.5 is an X86 system that uses a mix of ACPI and OF to populate
> devices. The root cause seems to be ISA devices not setting their fwnode
> field. But trying to figure out how to fix that doesn't seem worth the
> trouble because the OLPC devicetree is very sparse/limited and fw_devlink
> only adds the links causing this issue. Considering that there aren't many
> users of OF in an X86 system, simply fw_devlink DT support for X86.
>
> [1] - https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@web.de/
> Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""")
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> Cc: Andre Muller <andre.muller@web.de>
> ---
> drivers/of/property.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 0c0dc2e369c0..3fd74bb34819 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1444,6 +1444,9 @@ static int of_fwnode_add_links(struct fwnode_handle *fwnode)
> struct property *p;
> struct device_node *con_np = to_of_node(fwnode);
>
> + if (IS_ENABLED(CONFIG_X86))
> + return 0;
I love it :)
Anyway, getting a "Tested-by:" would be great to have here. Andre, can
you verify this solves your issue?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-10 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 1:14 [PATCH] of: property: Disable fw_devlink DT support for X86 Saravana Kannan
2021-09-10 6:15 ` Greg Kroah-Hartman [this message]
2021-09-10 10:37 ` Andre Muller
2021-09-10 11:15 ` Greg Kroah-Hartman
2021-09-10 16:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTr4CZW+rOXAjNq9@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andre.muller@web.de \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).