From: Michal Hocko <mhocko@suse.com>
To: Feng Tang <feng.tang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: detect allocation forbidden by cpuset and bail out early
Date: Fri, 10 Sep 2021 13:43:55 +0200 [thread overview]
Message-ID: <YTtE+/w1I/6uj70f@dhcp22.suse.cz> (raw)
In-Reply-To: <20210910112953.GB54659@shbuild999.sh.intel.com>
On Fri 10-09-21 19:29:53, Feng Tang wrote:
[...]
> > Sorry I didn't really get to read this previously. The implementation
> > works but I find it harder to read than really necessary. Why don't you
> > use first_zones_zonelist here as well?
>
> The concern I had was which zonelist to use, local node or the first node
> of nodemask's node_zonelists[ZONELIST_FALLBACK],
I am not sure I see your concern. Either of the two should work just
fine because all nodes should be reachable from the zonelist. But why
don't you simply do the same kind of check as in the page allocator?
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2021-09-10 11:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 8:25 [PATCH] mm/page_alloc: detect allocation forbidden by cpuset and bail out early Feng Tang
2021-09-07 8:44 ` Michal Hocko
2021-09-08 1:50 ` Feng Tang
2021-09-08 7:06 ` Michal Hocko
2021-09-08 8:12 ` Feng Tang
2021-09-10 7:44 ` Feng Tang
2021-09-10 8:35 ` Michal Hocko
2021-09-10 9:21 ` Feng Tang
2021-09-10 10:35 ` Michal Hocko
2021-09-10 11:29 ` Feng Tang
2021-09-10 11:43 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTtE+/w1I/6uj70f@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).