From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018AAC433F5 for ; Sat, 11 Sep 2021 00:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C870261153 for ; Sat, 11 Sep 2021 00:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234954AbhIKAKc (ORCPT ); Fri, 10 Sep 2021 20:10:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:48456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233946AbhIKAKb (ORCPT ); Fri, 10 Sep 2021 20:10:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 518C4611BF; Sat, 11 Sep 2021 00:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631318959; bh=0YuBUzN72gkNDxmeZ5kJyvvvXFpC+53qFp+/zstmt9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hmv5TRqSAS/BsSeUTEibp7up/z8FC7Zncd+zxhBvJXZt+59mJpA9lnYFUMKStarVU v9n6xzm0pz5TFMy2lLdAD56pxskSpwmyD/Qwk2x+0MsLPMkyWrsotNexrlUUx9sMTO QSXID0uMhcQaIcwYyLnChGlGf/5R6mim7v+zsF7QXsJEp++tdi4WOnL1w/6KKqOrjm qsL7W0FvrIpKokD0DvJUHnYFgYO7R2AGXcQLtj7If5DoSexiavFxZ5n+J9GyJ9qmJ9 Q35lu2pPDxaoTktyiqVGVW86G2k5MwHRlFUzHFd4/eCIXkbEFVS7wtHRouXbvGH2zU 1IASjekyXc0Bg== Date: Fri, 10 Sep 2021 17:09:14 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Andrew Morton , Linus Torvalds , Rasmus Villemoes , Masahiro Yamada , Joe Perches , Arnd Bergmann , Stephen Rothwell , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Subject: Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I Message-ID: References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-6-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910234047.1019925-6-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: > The minimum supported version of GCC is now 5.1. The check wasn't > correct as written anyways since GCC_VERSION is 0 when CC=clang. > > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: linux-riscv@lists.infradead.org > Signed-off-by: Nick Desaulniers Indeed, I meant to clean this up a while ago but forgot :/ Reviewed-by: Nathan Chancellor > --- > arch/riscv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index c79955655fa4..5fc1d0cc82e1 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -235,7 +235,7 @@ config ARCH_RV32I > config ARCH_RV64I > bool "RV64I" > select 64BIT > - select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000 > + select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 > select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8) > select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL > -- > 2.33.0.309.g3052b89438-goog > >