From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pratyush Yadav <p.yadav@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-spi@vger.kernel.org, git@xilinx.com,
saikrishna12468@gmail.com, Arnd Bergmann <arnd@arndb.de>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Subject: Re: [PATCH 1/4] firmware: xilinx: Add OSPI Mux selection support
Date: Fri, 24 Sep 2021 14:22:07 +0200 [thread overview]
Message-ID: <YU3C7y833i9f0+yB@kroah.com> (raw)
In-Reply-To: <c588c9c4-df4b-a617-35d1-23c32654d5ff@xilinx.com>
On Fri, Sep 24, 2021 at 02:12:55PM +0200, Michal Simek wrote:
>
>
> On 9/24/21 1:36 PM, Greg Kroah-Hartman wrote:
> > On Fri, Sep 24, 2021 at 03:37:08PM +0530, Sai Krishna Potthuri wrote:
> >> Add OSPI Mux selection API support to select the AXI interface to OSPI.
> >>
> >> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
> >> ---
> >> drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++
> >> include/linux/firmware/xlnx-zynqmp.h | 12 ++++++++++++
> >> 2 files changed, 29 insertions(+)
> >>
> >> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> >> index 15b138326ecc..43c3b5a9eef7 100644
> >> --- a/drivers/firmware/xilinx/zynqmp.c
> >> +++ b/drivers/firmware/xilinx/zynqmp.c
> >> @@ -647,6 +647,23 @@ int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type)
> >> }
> >> EXPORT_SYMBOL_GPL(zynqmp_pm_sd_dll_reset);
> >>
> >> +/**
> >> + * zynqmp_pm_ospi_mux_select() - OSPI Mux selection
> >> + *
> >> + * @dev_id: Device Id of the OSPI device.
> >> + * @select: OSPI Mux select value.
> >> + *
> >> + * This function select the OSPI Mux.
> >> + *
> >> + * Return: Returns status, either success or error+reason
> >> + */
> >> +int zynqmp_pm_ospi_mux_select(u32 dev_id, u32 select)
> >> +{
> >> + return zynqmp_pm_invoke_fn(PM_IOCTL, dev_id, IOCTL_OSPI_MUX_SELECT,
> >> + select, 0, NULL);
> >> +}
> >> +EXPORT_SYMBOL_GPL(zynqmp_pm_ospi_mux_select);
> >> +
> >> /**
> >> * zynqmp_pm_write_ggs() - PM API for writing global general storage (ggs)
> >> * @index: GGS register index
> >> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> >> index 9d1a5c175065..6979a79f553a 100644
> >> --- a/include/linux/firmware/xlnx-zynqmp.h
> >> +++ b/include/linux/firmware/xlnx-zynqmp.h
> >> @@ -119,6 +119,7 @@ enum pm_ioctl_id {
> >> IOCTL_READ_PGGS = 15,
> >> /* Set healthy bit value */
> >> IOCTL_SET_BOOT_HEALTH_STATUS = 17,
> >> + IOCTL_OSPI_MUX_SELECT = 21,
> >
> > Why the gap? What are the commands in the middle for?
>
> Below is the full list. Not everything has been upstream yet. There was
> an attempt on AFI which one colleague is working on and should send new
> version soon. I don't think anybody has started with upstreaming probe
> counters.
> Every part has different owner with unfortunately own upstreaming plan.
>
> Thanks,
> Michal
>
> enum pm_ioctl_id {
> IOCTL_GET_RPU_OPER_MODE = 0,
> IOCTL_SET_RPU_OPER_MODE = 1,
> IOCTL_RPU_BOOT_ADDR_CONFIG = 2,
> IOCTL_TCM_COMB_CONFIG = 3,
> IOCTL_SET_TAPDELAY_BYPASS = 4,
> IOCTL_SET_SGMII_MODE = 5,
> IOCTL_SD_DLL_RESET = 6,
> IOCTL_SET_SD_TAPDELAY = 7,
> IOCTL_SET_PLL_FRAC_MODE = 8,
> IOCTL_GET_PLL_FRAC_MODE = 9,
> IOCTL_SET_PLL_FRAC_DATA = 10,
> IOCTL_GET_PLL_FRAC_DATA = 11,
> IOCTL_WRITE_GGS = 12,
> IOCTL_READ_GGS = 13,
> IOCTL_WRITE_PGGS = 14,
> IOCTL_READ_PGGS = 15,
> /* IOCTL for ULPI reset */
> IOCTL_ULPI_RESET = 16,
> /* Set healthy bit value */
> IOCTL_SET_BOOT_HEALTH_STATUS = 17,
> IOCTL_AFI = 18,
> /* Probe counter read/write */
> IOCTL_PROBE_COUNTER_READ = 19,
> IOCTL_PROBE_COUNTER_WRITE = 20,
> IOCTL_OSPI_MUX_SELECT = 21,
> /* IOCTL for USB power request */
> IOCTL_USB_SET_STATE = 22,
> /* IOCTL to get last reset reason */
> IOCTL_GET_LAST_RESET_REASON = 23,
> /* AI engine NPI ISR clear */
> IOCTL_AIE_ISR_CLEAR = 24,
> /* Register SGI to ATF */
> IOCTL_REGISTER_SGI = 25,
> /* Runtime feature configuration */
> IOCTL_SET_FEATURE_CONFIG = 26,
> IOCTL_GET_FEATURE_CONFIG = 27,
> };
Odd mix of comments and no comments...
Anyway, that's fine, just curious as to why there was a gap. No real
reason why you can't just add them all now right?
thanks,
greg k-h
next prev parent reply other threads:[~2021-09-24 12:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 10:07 [PATCH 0/4] spi: cadence-quadspi: Add Xilinx Versal OSPI support Sai Krishna Potthuri
2021-09-24 10:07 ` [PATCH 1/4] firmware: xilinx: Add OSPI Mux selection support Sai Krishna Potthuri
2021-09-24 11:36 ` Greg Kroah-Hartman
2021-09-24 12:12 ` Michal Simek
2021-09-24 12:22 ` Greg Kroah-Hartman [this message]
2021-09-24 12:49 ` Michal Simek
2021-09-24 13:44 ` Greg Kroah-Hartman
2021-09-24 10:07 ` [PATCH 2/4] dt-bindings: spi: cadence-quadspi: Add support for Xilinx Versal OSPI Sai Krishna Potthuri
2021-09-24 12:45 ` Rob Herring
2021-10-04 16:59 ` Rob Herring
2021-09-24 10:07 ` [PATCH 3/4] spi: cadence-quadspi: Add OSPI support for Xilinx Versal SoC Sai Krishna Potthuri
2021-09-24 10:07 ` [PATCH 4/4] spi: cadence-quadspi: Add Xilinx Versal external DMA support Sai Krishna Potthuri
2021-10-02 0:16 ` [PATCH 0/4] spi: cadence-quadspi: Add Xilinx Versal OSPI support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU3C7y833i9f0+yB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=iwamatsu@nigauri.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).