From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] x86/mce: Get rid of the ->quirk_no_way_out() indirect call
Date: Fri, 24 Sep 2021 20:04:49 +0000 [thread overview]
Message-ID: <YU4vYSKnfdxzJFgZ@yaz-ubuntu> (raw)
In-Reply-To: <YUyZDAGloQB/M4ts@zn.tnic>
On Thu, Sep 23, 2021 at 05:11:08PM +0200, Borislav Petkov wrote:
> On Thu, Sep 23, 2021 at 02:51:49PM +0000, Yazen Ghannam wrote:
...
> > Do you recommend this create another quirk flag and follow this patch? Or
> > should the quirks be grouped together somehow?
>
> Does that quirk match machines with mce_flags.smca=1 per chance?
>
> :-)
>
Yes, at the moment it does. So I'll use that. Thanks!
> Also, your test:
>
> + if ((m->mcgstatus & (MCG_STATUS_EIPV|MCG_STATUS_RIPV)) != 0)
> + return;
>
> should be
>
> + if ((m->mcgstatus & (MCG_STATUS_EIPV|MCG_STATUS_RIPV)) ==
> (MCG_STATUS_EIPV|MCG_STATUS_RIPV))
> + return;
>
> methinks.
>
> Unless I'm misunderstanding the erratum ofc...
>
> --
The check is intended to catch the case where both bits are 0. But I'll
double-check with the hardware folks.
Thanks,
Yazen
prev parent reply other threads:[~2021-09-24 20:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 10:53 [PATCH 0/4] x86/mce: Remove indirect calls Borislav Petkov
2021-09-17 10:53 ` [PATCH 1/4] x86/mce: Get rid of the mce_severity function pointer Borislav Petkov
2021-09-17 10:53 ` [PATCH 2/4] x86/mce: Get rid of machine_check_vector Borislav Petkov
2021-09-20 4:57 ` Luck, Tony
2021-09-20 7:42 ` Rasmus Villemoes
2021-09-20 8:15 ` Borislav Petkov
2021-09-20 8:12 ` Borislav Petkov
2021-09-20 16:04 ` Luck, Tony
2021-09-20 16:32 ` Borislav Petkov
2021-09-17 10:53 ` [PATCH 3/4] x86/mce: Get rid of msr_ops Borislav Petkov
2021-09-20 4:47 ` Luck, Tony
2021-09-20 8:32 ` Borislav Petkov
2021-09-22 12:16 ` Borislav Petkov
2021-09-22 13:23 ` Luck, Tony
2021-09-22 13:55 ` Borislav Petkov
2021-09-22 15:22 ` Luck, Tony
2021-09-22 15:57 ` Borislav Petkov
2021-09-17 10:53 ` [PATCH 4/4] x86/mce: Get rid of the ->quirk_no_way_out() indirect call Borislav Petkov
2021-09-20 5:06 ` Luck, Tony
2021-09-20 8:34 ` Borislav Petkov
2021-09-23 14:51 ` Yazen Ghannam
2021-09-23 15:11 ` Borislav Petkov
2021-09-24 20:04 ` Yazen Ghannam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU4vYSKnfdxzJFgZ@yaz-ubuntu \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).