From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516BAC433FE for ; Tue, 14 Sep 2021 13:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 303AE60E90 for ; Tue, 14 Sep 2021 13:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbhINN63 (ORCPT ); Tue, 14 Sep 2021 09:58:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233874AbhINN6A (ORCPT ); Tue, 14 Sep 2021 09:58:00 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3A7DC0613E4 for ; Tue, 14 Sep 2021 06:56:41 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id u16so20385299wrn.5 for ; Tue, 14 Sep 2021 06:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BJpmi1XQksrmE+6cGS/DGj3dgnRtNEKtYHayJmsAAoM=; b=D4yt3Kc0GRkRqagRUNCu1KyedAtKxU/j+US12IdwxoOA+U7jkce9ZVoihpqUUne4PL TZzhvCKdolmMybBxCL31yulCMPTV64YgK7uSbxLVU441h8cStTdAWyjYeRTudwKMsoBx nzGOwcyeFt88uPl+BVP1gtgJA/oIfB7pgtb7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=BJpmi1XQksrmE+6cGS/DGj3dgnRtNEKtYHayJmsAAoM=; b=yTaJNEcuGARmjyu/fHUmx+xHjSOcmMixsRMMzuXCTkKycIboEWgsFSNDZ/ihAp/AD7 uoT0/s5XplILwSMXvaardvS3s+ixzk7LoejwOJyOnJFTAGXVykPa1q0zDauy+JMbg5Ow f/6m3ctaJKXTbtIdo6GwYftqLSnM5zcBBJ3nFBp9iJteUv/w9InRFTqCeR7+ox2myXW8 dz/1tjGm7Ze05R6juEl1SQmvLD3p5co15sF/1fFVyawJZBY7pWklrnpRLfdlnI1E/PyS mTj7qax2lSUpgIR6106iiIEoHdS3g19K5fUVe8ZRq8LDyXxttvsM0lMyVxtNk/dOemSd iYMg== X-Gm-Message-State: AOAM533Sh2PBWDv2X+9cibBBFt7iuy0gnupcmZ+XqoRcpi+hHCRocT87 z87hBarICNwPYmsUAmByNl04tV/b1vUYMA== X-Google-Smtp-Source: ABdhPJyDKElqKL755NRY0ePXn8wKr8HnluL3UEt4MtxABidMGqXOp6zHr06thq+3q69ls1ttFDdZaA== X-Received: by 2002:a5d:44d1:: with SMTP id z17mr10016355wrr.187.1631627800311; Tue, 14 Sep 2021 06:56:40 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id y8sm3539342wrh.44.2021.09.14.06.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 06:56:39 -0700 (PDT) Date: Tue, 14 Sep 2021 15:56:37 +0200 From: Daniel Vetter To: John Stultz Cc: lkml , Daniel Vetter , Christian Koenig , Sumit Semwal , Liam Mark , Chris Goldsworthy , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , =?iso-8859-1?Q?=D8rjan?= Eide , Robin Murphy , Simon Ser , James Jones , Leo Yan , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] dma-buf: system_heap: Avoid warning on mid-order allocations Message-ID: Mail-Followup-To: John Stultz , lkml , Christian Koenig , Sumit Semwal , Liam Mark , Chris Goldsworthy , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , =?iso-8859-1?Q?=D8rjan?= Eide , Robin Murphy , Simon Ser , James Jones , Leo Yan , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20210909023741.2592429-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210909023741.2592429-1-john.stultz@linaro.org> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 02:37:41AM +0000, John Stultz wrote: > When trying to do mid-order allocations, set __GFP_NOWARN to > avoid warning messages if the allocation fails, as we will > still fall back to single page allocatitions in that case. > This is the similar to what we already do for large order > allocations. > > Cc: Daniel Vetter > Cc: Christian Koenig > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Chris Goldsworthy > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Ørjan Eide > Cc: Robin Murphy > Cc: Simon Ser > Cc: James Jones > Cc: Leo Yan > Cc: linux-media@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz Acked-by: Daniel Vetter > --- > drivers/dma-buf/heaps/system_heap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c > index 23a7e74ef966..f57a39ddd063 100644 > --- a/drivers/dma-buf/heaps/system_heap.c > +++ b/drivers/dma-buf/heaps/system_heap.c > @@ -40,11 +40,12 @@ struct dma_heap_attachment { > bool mapped; > }; > > +#define LOW_ORDER_GFP (GFP_HIGHUSER | __GFP_ZERO | __GFP_COMP) > +#define MID_ORDER_GFP (LOW_ORDER_GFP | __GFP_NOWARN) > #define HIGH_ORDER_GFP (((GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN \ > | __GFP_NORETRY) & ~__GFP_RECLAIM) \ > | __GFP_COMP) > -#define LOW_ORDER_GFP (GFP_HIGHUSER | __GFP_ZERO | __GFP_COMP) > -static gfp_t order_flags[] = {HIGH_ORDER_GFP, LOW_ORDER_GFP, LOW_ORDER_GFP}; > +static gfp_t order_flags[] = {HIGH_ORDER_GFP, MID_ORDER_GFP, LOW_ORDER_GFP}; > /* > * The selection of the orders used for allocation (1MB, 64K, 4K) is designed > * to match with the sizes often found in IOMMUs. Using order 4 pages instead > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch