From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2884FC433EF for ; Thu, 16 Sep 2021 14:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04C0A6124B for ; Thu, 16 Sep 2021 14:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239029AbhIPO7M (ORCPT ); Thu, 16 Sep 2021 10:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235474AbhIPO7K (ORCPT ); Thu, 16 Sep 2021 10:59:10 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6916CC061764 for ; Thu, 16 Sep 2021 07:57:50 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id c42-20020a05683034aa00b0051f4b99c40cso8722627otu.0 for ; Thu, 16 Sep 2021 07:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2ojGxC9vujlZc6BKBj4erHX2ecNDJAjcVaF4hMOlH4o=; b=mIxrq7XkbBn6Zxtgzhd+JfrtYQifKCFKvMjoInuUAeT+oearKX4kwCosgE4+vxlWpX HazLhxZUv1kcyk8S2Y/eJaxxvCvjQHZ1Lf1ZeOg6SNn9kGrvYckflN+gpKbgwuctJPQz +zuBzTDsf08/rLD1cNd4GBx5bZSI8v4xCbioFbzh4T6nZO0znfa8oTMlKfqlJfoM7pd9 1MHmteJmnPla195abUIc7dPgv118di4y6QaGXvva/zDTZUifBN2bRkBA4FRLmla/2xP4 /k6IyqBFZmGTGTRjCAymnuGOd4rNwGvBshkV1ltWMk7s+iMfFitYqpvScHokaubHIoXi ARsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2ojGxC9vujlZc6BKBj4erHX2ecNDJAjcVaF4hMOlH4o=; b=R3AKJWGvTJQMP+5RMQ2CInEFxBnkkMUAd/HyemL0Jf1kyqYwdAdFkM1zM4lgHLzLuQ FPHXGDt2AtfpmbNNfcP+OsWlAvdqMsRtTFC0EQvgIR4uUBuzGAOxXNWe09/NUyvMV3zm n17o51cVFtg+q7g4a3Zw5Ou3ZN4hUEc/HlZHUMA4AQwfnxcUXaEmxHGABQCXS2xCyu/9 QInJ8B6peGtgxBtf9xtAoTa6jF3CyPfuaGJQojASclo0QdOcEdr1e+TGkRz3fiTu4rLM V7hZdHhPdc5TCiHKhqFvssLiR0TMlZIzxkdRBEHqmOztXE0AioBirJMq1ZbfDyOjejqS FSjA== X-Gm-Message-State: AOAM5315EHcSEm8pDqTfHelOQw7ySGXESSufV9DzjQ0f559n8XIGIkzL NqXOFRQccJNdDoOTCofOqk4xaQ== X-Google-Smtp-Source: ABdhPJxvx5aZVF3jwkCQ9pRxe/zGSTNOvZZirDWCK8+/Ou26JoxFK38MBnpygOQrI2sTDdpH41xq7A== X-Received: by 2002:a9d:6046:: with SMTP id v6mr5168492otj.234.1631804269687; Thu, 16 Sep 2021 07:57:49 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id l21sm761050oop.22.2021.09.16.07.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 07:57:49 -0700 (PDT) Date: Thu, 16 Sep 2021 07:58:38 -0700 From: Bjorn Andersson To: Amit Pundir Cc: Andy Gross , Rob Herring , Alex Elder , linux-arm-msm , dt , lkml Subject: Re: [PATCH] arm64: dts: qcom: sdm850-yoga: Enable IPA Message-ID: References: <20210615232816.835325-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16 Sep 03:52 PDT 2021, Amit Pundir wrote: > Hi Bjorn, > > On Wed, 16 Jun 2021 at 04:58, Bjorn Andersson > wrote: > > > > Shuffle memory regions to make firmware loading succeed and then enable > > the ipa device. > > Just a heads-up, this reserved memory region shuffling in sdm845.dtsi > broke PocoF1 and may be other devices too(?) which do not override > these regions. > Thanks for the report! > IIRC you once had a patch to move the reserved memory regions to board > specific dts files, is it still on the cards so that we don't run into > breakages like this? > As you might remember the feedback I got was to not move the regions to the individual devices and it was better to just deal with the problem this way... But apparently I was too optimistic and should have played the usual game of deleting the inherited nodes and made the changes in the yoga dts... > Meanwhile I'll go and add these regions in sdm845-xiaomi-beryllium.dts. > Let's prepare a fix that moves this change into the yoga.dts and get that landed asap. Regards, Bjorn > Regards, > Amit Pundir > > > > > > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 21 +++++++------------ > > .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 5 +++++ > > 2 files changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > index 1796ae8372be..49624eadce84 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > @@ -128,28 +128,23 @@ camera_mem: memory@8bf00000 { > > no-map; > > }; > > > > - ipa_fw_mem: memory@8c400000 { > > - reg = <0 0x8c400000 0 0x10000>; > > + wlan_msa_mem: memory@8c400000 { > > + reg = <0 0x8c400000 0 0x100000>; > > no-map; > > }; > > > > - ipa_gsi_mem: memory@8c410000 { > > - reg = <0 0x8c410000 0 0x5000>; > > + gpu_mem: memory@8c515000 { > > + reg = <0 0x8c515000 0 0x2000>; > > no-map; > > }; > > > > - gpu_mem: memory@8c415000 { > > - reg = <0 0x8c415000 0 0x2000>; > > + ipa_fw_mem: memory@8c517000 { > > + reg = <0 0x8c517000 0 0x5a000>; > > no-map; > > }; > > > > - adsp_mem: memory@8c500000 { > > - reg = <0 0x8c500000 0 0x1a00000>; > > - no-map; > > - }; > > - > > - wlan_msa_mem: memory@8df00000 { > > - reg = <0 0x8df00000 0 0x100000>; > > + adsp_mem: memory@8c600000 { > > + reg = <0 0x8c600000 0 0x1a00000>; > > no-map; > > }; > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > index c2a709a384e9..3eaa42dc3794 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > > @@ -415,6 +415,11 @@ ecsh: hid@5c { > > }; > > }; > > > > +&ipa { > > + status = "okay"; > > + memory-region = <&ipa_fw_mem>; > > +}; > > + > > &mdss { > > status = "okay"; > > }; > > -- > > 2.31.0 > >