From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF1EC433F5 for ; Fri, 17 Sep 2021 14:45:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D39A860FED for ; Fri, 17 Sep 2021 14:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232338AbhIQOrH (ORCPT ); Fri, 17 Sep 2021 10:47:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhIQOp5 (ORCPT ); Fri, 17 Sep 2021 10:45:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D24860F5B; Fri, 17 Sep 2021 14:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631889875; bh=+Hg/+BfWwo03yKEs5Bbuny3+dk6KDoxUqDrZJkTkIM0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r3zRsZNEddp6obXcwYzM/GjWxK+HxAoSYubfD8EcE37EiYioYi7QmPRdyOJdsCueM m1TLt856AWgCdw4D7vJMYaUttfngVoI+1nO6sUQzbBkJsAqYo+azJffUVUFDvJA4YF WoY8G3T0GBrXxito+C0oKplLWtZ/AQGmUr2GleBw= Date: Fri, 17 Sep 2021 16:44:33 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter Subject: Re: [PATCH v7 16/19] staging: r8188eu: clean up rtw_read*() and rtw_write*() Message-ID: References: <20210917071837.10926-1-fmdefrancesco@gmail.com> <20210917071837.10926-17-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917071837.10926-17-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2021 at 09:18:34AM +0200, Fabio M. De Francesco wrote: > Clean up rtw_read{8,16,32}() and rtw_write{8,16,32,N}() in usb_ops_linux.c. > > 1) Rename variables: > length => len > pio_priv => io_priv > pintfhdl => intfhdl > wvalue => address. > 2) Remove unnecessary casts. > 3) Fix types. Use __le16 instead of __le32. Again, should be 3 changes. thanks, greg k-h