From: Mike Rapoport <rppt@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
David Hildenbrand <david@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Alex Bee <knaerzche@gmail.com>, Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases)
Date: Sat, 18 Sep 2021 14:39:49 +0300 [thread overview]
Message-ID: <YUXQBV6KKi+/Q6gX@kernel.org> (raw)
In-Reply-To: <YUWlO2tZC5IwCAHV@kernel.org>
On Sat, Sep 18, 2021 at 11:37:22AM +0300, Mike Rapoport wrote:
> On Sat, Sep 18, 2021 at 07:18:43AM +0200, Christoph Hellwig wrote:
> > On Sat, Sep 18, 2021 at 12:22:47AM +0300, Mike Rapoport wrote:
> > > I did some digging and it seems that the most "generic" way to check if a
> > > page is in RAM is page_is_ram(). It's not 100% bullet proof as it'll give
> > > false negatives for architectures that do not register "System RAM", but
> > > those are not using dma_map_resource() anyway and, apparently, never would.
> >
> > The downside of page_is_ram is that it looks really expensiv for
> > something done at dma mapping time.
>
> Indeed :(
> But pfn_valid is plain wrong...
> I'll keep digging.
I did some more archaeology and it that check for pfn_valid() was requested
by arm folks because their MMU may have troubles with alias mappings with
different attributes and so they made the check to use a false assumption
that pfn_valid() == "RAM".
As this WARN_ON(pfn_valid()) is only present in dma_map_resource() it's
probably safe to drop it entirely.
Otherwise the simplest way would be to hide it behind something like
ARCH_WANTS_DMA_NOT_RAM and make arm/arm64 select it.
Thoughts?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-09-18 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 13:40 [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Alex Bee
2021-08-24 17:37 ` Catalin Marinas
2021-08-24 18:06 ` Robin Murphy
2021-08-24 18:28 ` Mike Rapoport
2021-08-24 18:46 ` Robin Murphy
2021-08-24 18:59 ` David Hildenbrand
2021-08-25 10:20 ` Catalin Marinas
2021-08-25 10:28 ` Will Deacon
2021-08-25 10:32 ` Will Deacon
2021-08-25 10:33 ` Robin Murphy
2021-08-25 10:38 ` David Hildenbrand
2021-08-25 10:54 ` Mike Rapoport
2021-08-25 10:55 ` Catalin Marinas
2021-08-25 11:12 ` David Hildenbrand
2021-08-25 17:15 ` Catalin Marinas
2021-08-25 10:58 ` Robin Murphy
2021-08-25 11:21 ` David Hildenbrand
2021-08-25 10:52 ` Mike Rapoport
2021-09-17 21:22 ` Mike Rapoport
2021-09-18 5:18 ` Christoph Hellwig
2021-09-18 8:37 ` Mike Rapoport
2021-09-18 11:39 ` Mike Rapoport [this message]
2021-09-20 10:57 ` Catalin Marinas
2021-09-21 8:20 ` Christoph Hellwig
2021-09-21 9:34 ` Mike Rapoport
2021-09-21 15:38 ` Christoph Hellwig
2021-09-22 7:22 ` Mike Rapoport
2021-09-20 11:13 ` David Hildenbrand
2021-08-24 20:14 ` Alex Bee
2021-08-25 4:39 ` Mike Rapoport
2021-08-25 10:00 ` Alex Bee
2021-08-24 20:07 ` Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUXQBV6KKi+/Q6gX@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).