From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBFABC433F5 for ; Mon, 20 Sep 2021 11:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADD4660FED for ; Mon, 20 Sep 2021 11:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231400AbhITLtj (ORCPT ); Mon, 20 Sep 2021 07:49:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:57324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbhITLta (ORCPT ); Mon, 20 Sep 2021 07:49:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5C0760FED; Mon, 20 Sep 2021 11:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632138484; bh=9n3jrqRr0I4rgQ5T6bvqdRjR5RdGCJPu6TR7YWU4HAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rS0A4GOztpx0ALpS/ogEB8WGL9rdrUlhBXSEHIe1hhyjFqFD3DBji4iaIG3O1TlFb Df8rEyhu0R50BywEXU85vT6gw5VNMiMZIXl+trGyPjOFLkHgKpPcWRLEfaKPrHClUG ZyKeBHbvtVXIAj7aXXMUUOTvoX+e/Ps5gq87qJRc= Date: Mon, 20 Sep 2021 13:48:01 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Martin Kaiser Subject: Re: [PATCH v8 04/19] staging: r8188eu: reorder comments in usbctrl_vendorreq() Message-ID: References: <20210919235356.4151-1-fmdefrancesco@gmail.com> <20210919235356.4151-5-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919235356.4151-5-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 01:53:41AM +0200, Fabio M. De Francesco wrote: > Reorder comments in usbctrl_vendorreq() to follow the Linux style. > > Co-developed-by: Pavel Skripkin > Signed-off-by: Pavel Skripkin > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/r8188eu/hal/usb_ops_linux.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c > index d92bdcc3716d..9138b730490f 100644 > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c > @@ -35,9 +35,11 @@ static int usbctrl_vendorreq(struct intf_hdl *intfhdl, u16 value, void *data, u1 > io_buf = dvobjpriv->usb_vendor_req_buf; > > if (requesttype == REALTEK_USB_VENQT_READ) > - pipe = usb_rcvctrlpipe(udev, 0);/* read_in */ > + /* read in */ > + pipe = usb_rcvctrlpipe(udev, 0); > else > - pipe = usb_sndctrlpipe(udev, 0);/* write_out */ > + /* write out */ > + pipe = usb_sndctrlpipe(udev, 0); For single-line if statements, that's not really needed. Just drop the comments entirely, the code here is "obvious". thanks, greg k-h