From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B425C433EF for ; Mon, 20 Sep 2021 11:47:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35E486108E for ; Mon, 20 Sep 2021 11:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237273AbhITLsy (ORCPT ); Mon, 20 Sep 2021 07:48:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:56998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237229AbhITLso (ORCPT ); Mon, 20 Sep 2021 07:48:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DE766108C; Mon, 20 Sep 2021 11:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632138438; bh=XIPC8SBRxlf44yhtHeZmU5yKnbKe55y7VoY2t/bcuOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=glSIsseM2bRILVlDniTl5g54N/eQyyWY2f3BvO3M/JyEpdhZGMMSOyf4IpBjMApL7 ZJqsJZoOr+kfIi66qvCFQSDFh09iLfvutf4RvEHWvqNeLaCB51XHJVpZEulsmjttUk rKPjK72gNV2IAP1J+ujMeujsInr3af1BpqZM8EdY= Date: Mon, 20 Sep 2021 13:47:15 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Martin Kaiser Subject: Re: [PATCH v8 03/19] staging: r8188eu: remove unnecessary test in usbctrl_vendorreq() Message-ID: References: <20210919235356.4151-1-fmdefrancesco@gmail.com> <20210919235356.4151-4-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919235356.4151-4-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 01:53:40AM +0200, Fabio M. De Francesco wrote: > Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). Remove the > no more used "release_mutex:" label. You need to explain _why_ it is unnecessary. thanks, greg k-h