From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77008C4332F for ; Mon, 20 Sep 2021 11:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FFB961166 for ; Mon, 20 Sep 2021 11:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237240AbhITLue (ORCPT ); Mon, 20 Sep 2021 07:50:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbhITLuU (ORCPT ); Mon, 20 Sep 2021 07:50:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8B5FD6108C; Mon, 20 Sep 2021 11:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632138534; bh=OKUMEPr+LdUl+LywNfZOIjZmodlkdEiNYc1QEoqjxJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GSbRLGT+SrQhLS5nptVWn1D8yJzYNRwqtCbmIa621N3eW/+UBtRmXXEHgNA3rNCYt vRa8YK2IjYxi6GCrlwSReXBqRI+ZJhIRSKcayQ3b1OK63VZhd7024KWFvBdGH4LjZD 2XzkPqaM4jUiT/yc9JblXLOL1I4CVXqQwnaWwank= Date: Mon, 20 Sep 2021 13:48:51 +0200 From: Greg Kroah-Hartman To: "Fabio M. De Francesco" Cc: Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Martin Kaiser Subject: Re: [PATCH v8 07/19] staging: r8188eu: remove unnecessary comment in usbctrl_vendorreq() Message-ID: References: <20210919235356.4151-1-fmdefrancesco@gmail.com> <20210919235356.4151-8-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919235356.4151-8-fmdefrancesco@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 01:53:44AM +0200, Fabio M. De Francesco wrote: > Remove an unnecessary comment in usbctrl_vendorreq(). > > Co-developed-by: Pavel Skripkin > Signed-off-by: Pavel Skripkin > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/r8188eu/hal/usb_ops_linux.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c > index a52aeb2558ad..fc3da0fbf474 100644 > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c > @@ -73,7 +73,6 @@ static int usbctrl_vendorreq(struct intf_hdl *intfhdl, u16 value, void *data, u1 > /* status != len && status >= 0 */ > if (status > 0) { > if (requesttype == REALTEK_USB_VENQT_READ) { > - /* For Control read transfer, we have to copy the read data from io_buf to data. */ > memcpy(data, io_buf, len); > } And now you have a coding style issue :( Don't try to fix up one and add another one please. thanks, greg k-h