From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 056D0C433F5
	for <linux-kernel@archiver.kernel.org>; Mon, 20 Sep 2021 11:50:56 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id E3C5F6108E
	for <linux-kernel@archiver.kernel.org>; Mon, 20 Sep 2021 11:50:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236398AbhITLwU (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 20 Sep 2021 07:52:20 -0400
Received: from mail.kernel.org ([198.145.29.99]:58484 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230037AbhITLwR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Sep 2021 07:52:17 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E3126108C;
        Mon, 20 Sep 2021 11:50:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1632138651;
        bh=FC5/WvnXHQZxQUWEHUOw2WKBwIjE1qR8g7D2LZN8p4o=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=lPooQ1l3E+774gGGqDlfUSof//0AMIaqga2/H24UISk/TOzH0BpXLHhcnDgbF959F
         q58BhWJ0YpcqAc7uzph+LAvCaol8JnbepOom9sQ8xBx/HiPfdp0GouRev9VysoSjdN
         kEeEa7/juNIUhpRFpzdmbl6hQpIaIIxUgzjk3zz4=
Date:   Mon, 20 Sep 2021 13:50:48 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        David Laight <david.Laight@aculab.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Martin Kaiser <martin@kaiser.cx>
Subject: Re: [PATCH v8 12/19] staging: r8188eu: change the type of a variable
 in rtw_write16()
Message-ID: <YUh1mCpdcncATAkC@kroah.com>
References: <20210919235356.4151-1-fmdefrancesco@gmail.com>
 <20210919235356.4151-13-fmdefrancesco@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210919235356.4151-13-fmdefrancesco@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 20, 2021 at 01:53:49AM +0200, Fabio M. De Francesco wrote:
> Change the type of "data" from __le32 to __le16.

You are saying _what_ you are doing here, but it is not obvious at all
_why_ you need to do this.

Please explain the why here when you redo this series.

thanks,

greg k-h