From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2EFC433F5 for ; Mon, 20 Sep 2021 21:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3AEE61166 for ; Mon, 20 Sep 2021 21:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237649AbhITVWj (ORCPT ); Mon, 20 Sep 2021 17:22:39 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:37504 "EHLO mail-ot1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234458AbhITVUe (ORCPT ); Mon, 20 Sep 2021 17:20:34 -0400 Received: by mail-ot1-f44.google.com with SMTP id w64-20020a9d3646000000b0054716b40005so4434209otb.4; Mon, 20 Sep 2021 14:19:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aDwWZhZ+JqLWINJ9PBWjjprFme0I94GN+ZK2QmZSREg=; b=zY+jxVQsFlRYt55w4A89s9UlZMo4iFyXuM4rIrj8XtXx5LsaV6uvF6+7Rt0BiJmgLu XgW6q/f02ooN97NuMjdw6njHb/hbYV39G4/sl95Xb3ZvHAeGSZAJpceT2kJFg89u+ci2 X5Stg3NBYZijF3xnbzGY9LMUsy2k6ZPmYPtF1lQOIoHcRyhL59tOII4QuzQsNqwVRfEe m8lPjFlGB7AoBoo3/qsW/FPfd3GPb2PBWioF4DxwTzxc6Dl0YFF/g0HZRsSPdLYF5aJZ Ze+uIiP9r7o+VaJve/VoORGYZNJdAfvZGKhTeBAOJufClyrjOr1TWjCp77omCGpugm0k erDA== X-Gm-Message-State: AOAM5327i1cgj97L00pPJy+LWlV/PxFNC++4CfUMGpVX+Pm0QEY31PLH 14uO1uuP7SJllDhswy0CQQ== X-Google-Smtp-Source: ABdhPJx3f4YFLCskuwGNYhf8vPy8jZ1Sjzlx0HNyVZO5/+wLIc/kmVv7xC42KpluZANdMdzendDhWg== X-Received: by 2002:a05:6830:43a0:: with SMTP id s32mr22937285otv.284.1632172746595; Mon, 20 Sep 2021 14:19:06 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id j17sm3737710ots.10.2021.09.20.14.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 14:19:06 -0700 (PDT) Received: (nullmailer pid 785129 invoked by uid 1000); Mon, 20 Sep 2021 21:19:05 -0000 Date: Mon, 20 Sep 2021 16:19:05 -0500 From: Rob Herring To: Apurva Nandan Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Serge Semin , Mark Brown , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, michael@walle.cc Subject: Re: [PATCH v2 2/2] dt-bindings: snps,dw-apb-ssi: Use 'flash' node name instead of 'spi-flash' in example Message-ID: References: <20210920142713.129295-1-a-nandan@ti.com> <20210920142713.129295-3-a-nandan@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920142713.129295-3-a-nandan@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 07:57:13PM +0530, Apurva Nandan wrote: > Change the nodename in the example with spi-nand from 'spi-flash@1' > to 'flash@1' to make the schema uniform with both spi-nand and spi-nor > flashes. jedec,spi-nor.yaml uses 'flash@' nodename for spi-nor flashes, > so make the spi-nand examples in dt-bindings use it too for uniformity. > > Signed-off-by: Apurva Nandan > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixes should come first. Maybe Mark can apply this before you respin. Acked-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index ca91201a9926..d7e08b03e204 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -171,7 +171,7 @@ examples: > cs-gpios = <&gpio0 13 0>, > <&gpio0 14 0>; > rx-sample-delay-ns = <3>; > - spi-flash@1 { > + flash@1 { > compatible = "spi-nand"; > reg = <1>; > rx-sample-delay-ns = <7>; > -- > 2.25.1 > >