From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1060FC433FE for ; Mon, 20 Sep 2021 21:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB9F660F48 for ; Mon, 20 Sep 2021 21:47:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238023AbhITVsg (ORCPT ); Mon, 20 Sep 2021 17:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238648AbhITVqe (ORCPT ); Mon, 20 Sep 2021 17:46:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9298C0698D7; Mon, 20 Sep 2021 10:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KXUOMDD9e8aDRtCMjdtKTE3I6iViL6D6eI7D8ogZ3mM=; b=uq96Xwj4pZdgwT/3V7FLk8WtPg YMjoJxWEbcNpxDi1aA5eIUP8wx2k0w+ft8EZAGVSpCUWeuytzVsMkniR9VUM4gcHG7SHsIGNgTeN7 r5namj2wGtuypxeRzCxkjfTLoWKWQiKxP+VK8622VncZUv/1U4dCQ9NpGDcVZFwarsCow3C82Dj6t XnHaV6EF3fXOVY244/V8StSsImq5wLyXbEUeKZ9X77Gy+mlahNPtgunAxs5zHauW5YHbtSIB7IyET +FPv+CFlwXUibadLtKUQF/9C9fPOgiO7dtRLPEDOgvo8CO6zXyKg+blvANJ6SoA9TlwhDSuwbJogK XHexOcHg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSN2Y-002uyi-DQ; Mon, 20 Sep 2021 17:25:40 +0000 Date: Mon, 20 Sep 2021 18:25:14 +0100 From: Matthew Wilcox To: Bartosz Golaszewski Cc: Geert Uytterhoeven , Christoph Hellwig , Joel Becker , Shuah Khan , Linus Walleij , Andy Shevchenko , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Kent Gibson , Jonathan Corbet , Greg Kroah-Hartman , Al Viro , Jack Winch , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , "open list:DOCUMENTATION" Subject: Re: [PATCH v5 2/8] configfs: use BIT() for internal flags Message-ID: References: <20210920140509.5177-1-brgl@bgdev.pl> <20210920140509.5177-3-brgl@bgdev.pl> <20210920140938.GA24424@lst.de> <20210920143046.GA26163@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 05:00:10PM +0200, Bartosz Golaszewski wrote: > Anyway, I'm more interested in Al's comments on the implementation of > committable items than bikeshedding about whether to use or not to use > BIT() so I'll wait for those before revisiting this patch. This isn't bikeshedding. Bikeshedding is when lots of people weigh in with opinions on what you should do. This is you failing to listen to the maintainer of the code you're changing.