linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bert Vermeulen <bert@biot.com>
Cc: John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB
Date: Mon, 20 Sep 2021 18:59:53 -0500	[thread overview]
Message-ID: <YUkgeedFfKnod288@robh.at.kernel.org> (raw)
In-Reply-To: <20210908141606.136792-3-bert@biot.com>

On Wed, Sep 08, 2021 at 04:16:03PM +0200, Bert Vermeulen wrote:
> From: John Crispin <john@phrozen.org>
> 
> Add devicetree binding for Airoha EN7523 SoC and evaluation board.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> ---
>  .../devicetree/bindings/arm/airoha.yaml       | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/airoha.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/airoha.yaml b/Documentation/devicetree/bindings/arm/airoha.yaml
> new file mode 100644
> index 000000000000..f2661ba81109
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/airoha.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/airoha.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha SoC based Platforms Device Tree Bindings
> +
> +maintainers:
> +  - Felix Fietkau <nbd@nbd.name>
> +  - John Crispin <john@phrozen.org>

Blank line.

> +description: |

Don't need '|' here.

> +  Boards with an Airoha SoC shall have the following properties.
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:

Don't need oneOf with only 1 entry.

> +      - items:
> +          - enum:
> +              - airoha,en7523-evb
> +          - const: airoha,en7523
> +
> +additionalProperties: true
> +
> +...
> -- 
> 2.25.1
> 
> 

  reply	other threads:[~2021-09-21  0:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 14:16 [PATCH v3 0/5] Add support for Airoha EN7523 SoC Bert Vermeulen
2021-09-08 14:16 ` [PATCH v3 1/5] dt-bindings: Add vendor prefix for Airoha Bert Vermeulen
2021-09-20 23:58   ` Rob Herring
2021-09-08 14:16 ` [PATCH v3 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Bert Vermeulen
2021-09-20 23:59   ` Rob Herring [this message]
2021-09-08 14:16 ` [PATCH v3 3/5] ARM: dts: Add basic support for Airoha EN7523 Bert Vermeulen
2021-09-08 14:16 ` [PATCH v3 4/5] ARM: Add basic support for Airoha EN7523 SoC Bert Vermeulen
2021-09-08 14:16 ` [PATCH v3 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen
2021-09-08 14:29 ` [PATCH v3 0/5] " Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUkgeedFfKnod288@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=bert@biot.com \
    --cc=devicetree@vger.kernel.org \
    --cc=john@phrozen.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).