From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F15C433F5 for ; Tue, 21 Sep 2021 13:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B68F760F6E for ; Tue, 21 Sep 2021 13:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbhIUNYf (ORCPT ); Tue, 21 Sep 2021 09:24:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:43128 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbhIUNYe (ORCPT ); Tue, 21 Sep 2021 09:24:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="220158710" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="220158710" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 06:23:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="613003776" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 21 Sep 2021 06:23:01 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 21 Sep 2021 16:23:00 +0300 Date: Tue, 21 Sep 2021 16:23:00 +0300 From: Heikki Krogerus To: Sven Peter Cc: Greg Kroah-Hartman , Guido =?iso-8859-1?Q?G=FCnther?= , Bryan O'Donoghue , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hector Martin , Mohamed Mediouni , Stan Skowronek , Mark Kettenis , Alexander Graf , Alyssa Rosenzweig Subject: Re: [RFT PATCH 4/9] usb: typec: tipd: Add short-circuit for no irqs Message-ID: References: <20210918120934.28252-1-sven@svenpeter.dev> <20210918120934.28252-5-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210918120934.28252-5-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 18, 2021 at 02:09:29PM +0200, Sven Peter wrote: > If no interrupts are set in IntEventX directly skip to the end of the > interrupt handler and return IRQ_NONE instead of IRQ_HANDLED. > This possibly allows to detect spurious interrupts if the i2c bus is fast > enough. > > Signed-off-by: Sven Peter Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tipd/core.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index c2c399722c37..4a6d66250fef 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -434,6 +434,8 @@ static irqreturn_t tps6598x_interrupt(int irq, void *data) > trace_tps6598x_irq(event1, event2); > > event = event1 | event2; > + if (!event) > + goto err_unlock; > > ret = tps6598x_read32(tps, TPS_REG_STATUS, &status); > if (ret) { > @@ -481,7 +483,9 @@ static irqreturn_t tps6598x_interrupt(int irq, void *data) > err_unlock: > mutex_unlock(&tps->lock); > > - return IRQ_HANDLED; > + if (event) > + return IRQ_HANDLED; > + return IRQ_NONE; > } > > static int tps6598x_check_mode(struct tps6598x *tps) > -- > 2.25.1 thanks, -- heikki