From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA62C433EF for ; Tue, 21 Sep 2021 13:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B183F60F9D for ; Tue, 21 Sep 2021 13:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233429AbhIUOBZ (ORCPT ); Tue, 21 Sep 2021 10:01:25 -0400 Received: from mga02.intel.com ([134.134.136.20]:57851 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233042AbhIUOBY (ORCPT ); Tue, 21 Sep 2021 10:01:24 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="210599486" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="210599486" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 06:40:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="613009248" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 21 Sep 2021 06:40:21 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 21 Sep 2021 16:40:20 +0300 Date: Tue, 21 Sep 2021 16:40:20 +0300 From: Heikki Krogerus To: Sven Peter Cc: Greg Kroah-Hartman , Guido =?iso-8859-1?Q?G=FCnther?= , Bryan O'Donoghue , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hector Martin , Mohamed Mediouni , Stan Skowronek , Mark Kettenis , Alexander Graf , Alyssa Rosenzweig Subject: Re: [RFT PATCH 6/9] usb: typec: tipd: Setup IntMask explicitly Message-ID: References: <20210918120934.28252-1-sven@svenpeter.dev> <20210918120934.28252-7-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210918120934.28252-7-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 18, 2021 at 02:09:31PM +0200, Sven Peter wrote: > Right now the code relies on the bootloader to set up the interrupt mask > correctly. This usually works but let's make sure to do it explicitly to > guarantee it will always work. > > Signed-off-by: Sven Peter > --- > drivers/usb/typec/tipd/core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index d191e7435018..2058e8cca631 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -728,6 +728,24 @@ static int tps6598x_probe(struct i2c_client *client) > dev_err(&client->dev, "failed to register partner\n"); > } > > + if (tps->hw->use_int1) { > + ret = tps6598x_write64(tps, TPS_REG_INT_MASK1, > + tps->hw->irq_power_status_update | > + tps->hw->irq_data_status_update | > + tps->hw->irq_plug_event); > + if (ret) > + goto err_role_put; > + } > + > + if (tps->hw->use_int2) { > + ret = tps6598x_write64(tps, TPS_REG_INT_MASK2, > + tps->hw->irq_power_status_update | > + tps->hw->irq_data_status_update | > + tps->hw->irq_plug_event); > + if (ret) > + goto err_role_put; > + } You should first only set the mask on your board. We can then see if it's something that should be done on other boards as well later. thanks, -- heikki