From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84AD7C433EF for ; Tue, 21 Sep 2021 14:02:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A65A60F9D for ; Tue, 21 Sep 2021 14:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233451AbhIUOEU (ORCPT ); Tue, 21 Sep 2021 10:04:20 -0400 Received: from mga18.intel.com ([134.134.136.126]:26012 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232981AbhIUOER (ORCPT ); Tue, 21 Sep 2021 10:04:17 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10113"; a="210443857" X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="210443857" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 06:41:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,311,1624345200"; d="scan'208";a="613009717" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 21 Sep 2021 06:41:37 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 21 Sep 2021 16:41:36 +0300 Date: Tue, 21 Sep 2021 16:41:36 +0300 From: Heikki Krogerus To: Sven Peter Cc: Greg Kroah-Hartman , Guido =?iso-8859-1?Q?G=FCnther?= , Bryan O'Donoghue , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hector Martin , Mohamed Mediouni , Stan Skowronek , Mark Kettenis , Alexander Graf , Alyssa Rosenzweig Subject: Re: [RFT PATCH 9/9] usb: typec: tipd: Remove FIXME about testing with I2C_FUNC_I2C Message-ID: References: <20210918120934.28252-1-sven@svenpeter.dev> <20210918120934.28252-10-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210918120934.28252-10-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 18, 2021 at 02:09:34PM +0200, Sven Peter wrote: > The Apple i2c bus uses I2C_FUNC_I2C and I've tested this quite > extensivly in the past days. Remove the FIXME about that testing :-) > > Signed-off-by: Sven Peter Reviewed-by: Heikki Krogerus > --- > drivers/usb/typec/tipd/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index 26807c050662..3b6878e22ce9 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -673,9 +673,6 @@ static int tps6598x_probe(struct i2c_client *client) > /* > * Checking can the adapter handle SMBus protocol. If it can not, the > * driver needs to take care of block reads separately. > - * > - * FIXME: Testing with I2C_FUNC_I2C. regmap-i2c uses I2C protocol > - * unconditionally if the adapter has I2C_FUNC_I2C set. > */ > if (i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) > tps->i2c_protocol = true; > -- > 2.25.1 thanks, -- heikki