From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE0FC433F5 for ; Wed, 22 Sep 2021 15:01:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 931AA611CA for ; Wed, 22 Sep 2021 15:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236383AbhIVPCr (ORCPT ); Wed, 22 Sep 2021 11:02:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:40526 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236303AbhIVPCq (ORCPT ); Wed, 22 Sep 2021 11:02:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D846D61107; Wed, 22 Sep 2021 15:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632322876; bh=+ndLHHJpqgiLl+AAzgT/7slj1gmNF6eITP0mUsOw7/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qPmzNAtcd4CM3U8j4HIh1/lqM8+Hddmpe0T2KDtU5omY27k+KjGypBUUj77++tfP+ eynyB8fSepmg6PSQ/zmVlDVePEvyeRQBbG5kV56K5NCFDQMvh4g+pO8mtMjO3gjxPh srja6zaJmblA6D0ou1iSKhg44i5Xga+nGduUJrvE= Date: Wed, 22 Sep 2021 17:01:14 +0200 From: Greg KH To: Jiri Slaby Cc: Dmitry Torokhov , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Andreas Koensgen , Paul Mackerras , Krzysztof Kozlowski Subject: Re: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl Message-ID: References: <20210914091134.17426-1-jslaby@suse.cz> <20210914091134.17426-7-jslaby@suse.cz> <9049e956-2865-7309-2eaf-aa4516ab28d6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 05:51:35PM +0200, Jiri Slaby wrote: > On 21. 09. 21, 13:36, Greg KH wrote: > > On Tue, Sep 21, 2021 at 12:52:38PM +0200, Jiri Slaby wrote: > > > On 21. 09. 21, 6:00, Dmitry Torokhov wrote: > > > > Hi Jiri, > > > > > > > > On Tue, Sep 14, 2021 at 11:11:25AM +0200, Jiri Slaby wrote: > > > > > diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c > > > > > index 17eb8f2aa48d..55e91d0e70ec 100644 > > > > > --- a/drivers/input/serio/serport.c > > > > > +++ b/drivers/input/serio/serport.c > > > > > @@ -207,8 +207,8 @@ static void serport_set_type(struct tty_struct *tty, unsigned long type) > > > > > * serport_ldisc_ioctl() allows to set the port protocol, and device ID > > > > > */ > > > > > -static int serport_ldisc_ioctl(struct tty_struct *tty, struct file *file, > > > > > - unsigned int cmd, unsigned long arg) > > > > > +static int serport_ldisc_ioctl(struct tty_struct *tty, unsigned int cmd, > > > > > + unsigned long arg) > > > > > > > > Can we please keep arguments aligned as they were? Otherwise > > > > > > Fixed, thanks. Likely, I will send a follow-up -- depending if Greg drops or > > > keeps these in the tree. > > > > Up to you. I can drop them all now if you want to resend a v2 with all > > of the aggregate acks, or you can send a follow-up set on top of these. > > What about if you keep everything up to (and incl.) > tty: remove file from n_tty_ioctl_helper > (i.e. the patch 06/16, the one before this one)? If that works for you, I > will send v2 of the rest w/ collected acks. If it doesn't, I prefer sending > a complete v2 (incl. collected acks). Ok, I have kept everything up to and including patch 06 of this series and pushed that out now. Feel free to rebase on my tty-next branch and resend the remaining changes. thanks, greg k-h