From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082CEC433F5 for ; Thu, 23 Sep 2021 00:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E31BB60FC1 for ; Thu, 23 Sep 2021 00:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238669AbhIWAcd (ORCPT ); Wed, 22 Sep 2021 20:32:33 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33548 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233466AbhIWAcc (ORCPT ); Wed, 22 Sep 2021 20:32:32 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3241FE52; Thu, 23 Sep 2021 02:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632357060; bh=EJ55Z1zJwBfIXFQCU8OpO167gyhJ46bJiR8/jqfwHJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CNhY2kbC7Vq7vtZtF/mPiDbmQrvjxwkYGEOxqx7o1x5pL9cIGssqCt28BMMVPPgER ciAxR2Js8meqDjQJMbawjJHr08OtwmJBMGH5HaVDFue80m8WSBw8igHW+wiWp+R04N 12U3xpzRelxOtBmx0IiIdM6n/w2kANLlVDzhsT7A= Date: Thu, 23 Sep 2021 03:30:58 +0300 From: Laurent Pinchart To: Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Douglas Anderson , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Subject: Re: [PATCH v2 2/3] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid() Message-ID: References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-3-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210920225801.227211-3-robdclark@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for the patch. On Mon, Sep 20, 2021 at 03:57:59PM -0700, Rob Clark wrote: > From: Rob Clark > > For the brave new world of bridges not creating their own connectors, we > need to implement the max clock limitation via bridge->mode_valid() > instead of connector->mode_valid(). > > v2: Drop unneeded connector->mode_valid() > > Signed-off-by: Rob Clark > Reviewed-by: Douglas Anderson Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 41d48a393e7f..6154bed0af5b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -615,20 +615,8 @@ static int ti_sn_bridge_connector_get_modes(struct drm_connector *connector) > return drm_bridge_get_modes(pdata->next_bridge, connector); > } > > -static enum drm_mode_status > -ti_sn_bridge_connector_mode_valid(struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* maximum supported resolution is 4K at 60 fps */ > - if (mode->clock > 594000) > - return MODE_CLOCK_HIGH; > - > - return MODE_OK; > -} > - > static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { > .get_modes = ti_sn_bridge_connector_get_modes, > - .mode_valid = ti_sn_bridge_connector_mode_valid, > }; > > static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { > @@ -766,6 +754,18 @@ static void ti_sn_bridge_detach(struct drm_bridge *bridge) > drm_dp_aux_unregister(&bridge_to_ti_sn65dsi86(bridge)->aux); > } > > +static enum drm_mode_status > +ti_sn_bridge_mode_valid(struct drm_bridge *bridge, > + const struct drm_display_info *info, > + const struct drm_display_mode *mode) > +{ > + /* maximum supported resolution is 4K at 60 fps */ > + if (mode->clock > 594000) > + return MODE_CLOCK_HIGH; > + > + return MODE_OK; > +} > + > static void ti_sn_bridge_disable(struct drm_bridge *bridge) > { > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > @@ -1127,6 +1127,7 @@ static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) > static const struct drm_bridge_funcs ti_sn_bridge_funcs = { > .attach = ti_sn_bridge_attach, > .detach = ti_sn_bridge_detach, > + .mode_valid = ti_sn_bridge_mode_valid, > .pre_enable = ti_sn_bridge_pre_enable, > .enable = ti_sn_bridge_enable, > .disable = ti_sn_bridge_disable, -- Regards, Laurent Pinchart