From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D62C433F5 for ; Thu, 23 Sep 2021 13:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE25260F39 for ; Thu, 23 Sep 2021 13:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232342AbhIWNJb (ORCPT ); Thu, 23 Sep 2021 09:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232388AbhIWNJa (ORCPT ); Thu, 23 Sep 2021 09:09:30 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91737C061756 for ; Thu, 23 Sep 2021 06:07:58 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id w29so16966783wra.8 for ; Thu, 23 Sep 2021 06:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rE6nnZCkTUCQWXqTRzlILH190eg8HrCKfBnNZwDr1Zo=; b=VV2tCq3SN8ulJhpc0E6jDm+p8kHvTGIWq0mPVdpqBKCELiHsCgpY8t7yIKoUsss3oA 9+FzKPqeQbvPha1ggffEuMX0eobcioNr0u/yhCbaX2f9zWv+bDZjx9dBH++SKlo/GxLc r/TV9g24RrZRebJvy82+h3DzTxGoYH5F7+Sn5Zw4bRLh0zYEREy6tCiAdaVQQBLsMFqD TEqeDIe/Uvm+ez7Bh9nbptOPACNTxy+kM8IRI6WEi9xScYcX+4S6ir5be7cL9yVqIsGg RSh+2wA+u9a9HWrQj/GvFVZYhD2+kbSEJ2j9ibvs7yvNvEjIyMB+XR0cFnxNRP0LjALK AhpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rE6nnZCkTUCQWXqTRzlILH190eg8HrCKfBnNZwDr1Zo=; b=kfAfQ12YPHZIwFRE2nEaHfSc7kO7y6kNowkoHYP4utlLWi+yceIr9c+7j4f2yZdx+l lIl3HcKoDp9GJX5Hv0w3GPp3qp8rS3tR471YHO0c/shfPCtuO1eFrLA2EAAuvVX2cGiF LU8zR8r184SlTd1VdTQAEtVXtRyax8mEx55y5g7c0ckELr9VD6tf0M8ECdVmHH3+Juwb 4KgH99Nfk9cr2256VY1oaOZIj9ON8CzokQk2P6KSVIFYi4qcMFGOnIMHiVaetPPIKJXq iWcimRuqfJCkJuorSy9+7cFMSAsRvhHcM5QbW78OKuVbEkcLX7iv37cWdj6d5Ue9Zu/D RyCw== X-Gm-Message-State: AOAM530FfKo66x9URwrEv5dJEouYJ4n++jOfe3hHNs22VW6a/4+tHDXy nm4o77SMZVuAZtOty10q9szzyw== X-Google-Smtp-Source: ABdhPJwuMnzsQggZhsSErxfF8pu9yl1541ldsvSrqOM8VzsHHyZLEe0lBR+TR8HxTw8LgR4Pqc47UQ== X-Received: by 2002:a1c:403:: with SMTP id 3mr4417280wme.161.1632402476975; Thu, 23 Sep 2021 06:07:56 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-137.home.otenet.gr. [94.66.220.137]) by smtp.gmail.com with ESMTPSA id b16sm5406560wrp.82.2021.09.23.06.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 06:07:56 -0700 (PDT) Date: Thu, 23 Sep 2021 16:07:53 +0300 From: Ilias Apalodimas To: Yunsheng Lin Cc: Jesper Dangaard Brouer , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Networking , open list , linuxarm@openeuler.org, Jesper Dangaard Brouer , Jonathan Lemon , Alexander Lobakin , Willem de Bruijn , Cong Wang , Paolo Abeni , Kevin Hao , Aleksandr Nogikh , Marco Elver , memxor@gmail.com, Eric Dumazet , Alexander Duyck , David Ahern Subject: Re: [PATCH net-next 1/7] page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA Message-ID: References: <20210922094131.15625-1-linyunsheng@huawei.com> <20210922094131.15625-2-linyunsheng@huawei.com> <0ffa15a1-742d-a05d-3ea6-04ff25be6a29@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 23, 2021 at 07:13:11PM +0800, Yunsheng Lin wrote: > On 2021/9/23 18:02, Ilias Apalodimas wrote: > > Hi Jesper, > > > > On Thu, 23 Sept 2021 at 12:33, Jesper Dangaard Brouer > > wrote: > >> > >> > >> On 22/09/2021 11.41, Yunsheng Lin wrote: > >>> diff --git a/net/core/page_pool.c b/net/core/page_pool.c > >>> index 1a6978427d6c..a65bd7972e37 100644 > >>> --- a/net/core/page_pool.c > >>> +++ b/net/core/page_pool.c > >>> @@ -49,6 +49,12 @@ static int page_pool_init(struct page_pool *pool, > >>> * which is the XDP_TX use-case. > >>> */ > >>> if (pool->p.flags & PP_FLAG_DMA_MAP) { > >>> + /* DMA-mapping is not supported on 32-bit systems with > >>> + * 64-bit DMA mapping. > >>> + */ > >>> + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > >>> + return -EINVAL; > >> > >> As I said before, can we please use another error than EINVAL. > >> We should give drivers a chance/ability to detect this error, and e.g. > >> fallback to doing DMA mappings inside driver instead. > >> > >> I suggest using EOPNOTSUPP 95 (Operation not supported). > > Will change it to EOPNOTSUPP, thanks. Mind sending this one separately (and you can keep my reviewed-by). It fits nicely on it's own and since I am not sure about the rest of the changes yet, it would be nice to get this one in. Cheers /Ilias > > > > > I am fine with both. In any case though the aforementioned driver can > > just remove PP_FLAG_DMA_MAP and do it's own mappings. > > > > Regards > > /Ilias > >> > >> -Jesper > >> > > . > >