From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD05C433FE for ; Wed, 6 Oct 2021 05:29:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 568CC611C5 for ; Wed, 6 Oct 2021 05:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232566AbhJFFbD (ORCPT ); Wed, 6 Oct 2021 01:31:03 -0400 Received: from muru.com ([72.249.23.125]:41228 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbhJFFbC (ORCPT ); Wed, 6 Oct 2021 01:31:02 -0400 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7B37080E1; Wed, 6 Oct 2021 05:29:40 +0000 (UTC) Date: Wed, 6 Oct 2021 08:29:08 +0300 From: Tony Lindgren To: Saravana Kannan Cc: Russell King , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Catalin Marinas , Will Deacon , Damien Le Moal , Greg Kroah-Hartman , Ulf Hansson , Rob Herring , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 0/2] Fix simple-bus issues with fw_devlink Message-ID: References: <20210929000735.585237-1-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929000735.585237-1-saravanak@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Saravana Kannan [210929 03:08]: > Ulf reported an issue[1] with fw_devlink. This series tries to fix that > issue. > > I replicated a similar set up on my end and I confirmed: > - A simple-bus only device is probed. > - Another device listing simple-bus as a 2nd compatible string isn't > probed. > > v1->v2: > - Switched to probing the simple-bus device instead of marking it as > NEVER_PROBES. > > v2->v3: > - Moved all the code into the simple-pm-bus driver > - Addressed Ulf's comment about the remove() code missing a check. > > v3->v4: > - Added support for driver_override to accommodate the case where new > transparent bus compatible strings are added to DT, but the kernel hasn't > been updated yet. > - Added/updated comments to give more details. > - Adding Ulf's Tested-by that he have for v3 (v4 didn't change by much). Works for me: Tested-by: Tony Lindgren