From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D57BC4332F for ; Wed, 6 Oct 2021 03:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F6AD6101B for ; Wed, 6 Oct 2021 03:35:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbhJFDhP (ORCPT ); Tue, 5 Oct 2021 23:37:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbhJFDhN (ORCPT ); Tue, 5 Oct 2021 23:37:13 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DAF3C061749 for ; Tue, 5 Oct 2021 20:35:20 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so1435512otq.7 for ; Tue, 05 Oct 2021 20:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2sbh8LLwhe0nCiTyzEPV2SKVkwsiELLTCq3fosoU3eY=; b=CjWp3tQXqVMU4eM/Dp4xP9dx5gR1kbkWFj9qKDDDpvaOnn1iV6QvRhvIhuov5BjYB/ kZDWWfvJL0yJhr46rXLxozF9dIDwcdWEvrbO6lOlL1TSoRbAuZYJdEOjI5a6hDl81R/h If9IlPYsS/KlslkIn1yT84KelCrJsELo8wC41lqaaBOXvrYKkurIzZqaghU/XR2iG/Y2 TmSkcxwCp8JIAxdhzjnxfZ46oZw9mXp57GoIgKUdQZU1dsfZz23PQ4a63kTmQurjj/5+ J2o6gz/HN1nrrWD3ga9Ff6XLOh0yjfrO5r9XYXRgvLBNEa6/dwcXzTNN/PUnJ3g+Jpku ZAlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2sbh8LLwhe0nCiTyzEPV2SKVkwsiELLTCq3fosoU3eY=; b=42fPgxGvcQP8hUD+s8UHzx7su2xwnIOTNF6rISNFbfx51R76GYdGwkqMD964HSuJ1C 9J5W2UZ6/t5M+4JEKPJ7tNc5TIkCGWDV01ih1aB5jLrZoiVnnBAPB/Xryv9JXgRM2C/B k2pWsXLJpNNFkKObP9IA2FM+V+VoquBL0TR5+DSXkvqTjPTEdl9Pe0hqelVX9hossfhS tC+iChXW7TNxNm6AOHYO80eSnKZ9pF8yHfyeRd13F4Ic7G0ipXR543793KzcTbjg8iHC stoJizZ0r12bEoLZEJLTRRX1CMHMm7SI14kmr8CNXDWYv8bbBZ5oAnZRp9SH5/AccVO+ 2lYA== X-Gm-Message-State: AOAM532Y9cxj0H9/kA22tZ5b43ylNpM3Lke7w+x7pdALHtVnvnAt+OsY yScgQD796906nrqeDE/59pVG5w== X-Google-Smtp-Source: ABdhPJzTy8d/HbUt5693DrCKpOktGkmrPUKavSTW1qTcXIrEfQMG1KpYwY3dDGC13/Rs5VW2onMJXA== X-Received: by 2002:a9d:6396:: with SMTP id w22mr17247964otk.26.1633491319916; Tue, 05 Oct 2021 20:35:19 -0700 (PDT) Received: from yoga ([2600:1700:a0:3dc8:c84c:8eff:fe1e:256f]) by smtp.gmail.com with ESMTPSA id w1sm3947298ote.41.2021.10.05.20.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 20:35:19 -0700 (PDT) Date: Tue, 5 Oct 2021 22:35:16 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Kalyan Thota , Kuogee Hsieh , Rob Clark , Sean Paul , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/7] drm/msm/dp: Allow specifying connector_type per controller Message-ID: References: <20211005231323.2663520-1-bjorn.andersson@linaro.org> <20211005231323.2663520-4-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 05 Oct 19:29 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-05 16:13:19) > > As the following patches introduced support for multiple DP blocks in a > > platform and some of those block might be eDP it becomes useful to be > > able to specify the connector type per block. > > > > Although there's only a single block at this point, the array of descs > > and the search in dp_display_get_desc() are introduced here to simplify > > the next patch, that does introduce support for multiple DP blocks. > > > > Signed-off-by: Bjorn Andersson > > --- > > > > Changes since v3: > > - New patch > > - Extended msm_dp_config with connector_type, wrapped in inner struct > > - Refactored out of the next patch > > - Pass the connector_type to drm_connector_init(), from yet another patch > > - Dropped double newline and unnecessary {} > > BTW, I see that we check for the connector type in debugfs. > > $ git grep DRM_MODE_CONNECTOR_DisplayPort -- drivers/gpu/drm/msm/dp/ > drivers/gpu/drm/msm/dp/dp_debug.c: > DRM_MODE_CONNECTOR_DisplayPort) > drivers/gpu/drm/msm/dp/dp_debug.c: > DRM_MODE_CONNECTOR_DisplayPort) > drivers/gpu/drm/msm/dp/dp_debug.c: > DRM_MODE_CONNECTOR_DisplayPort) > drivers/gpu/drm/msm/dp/dp_debug.c: > DRM_MODE_CONNECTOR_DisplayPort) > > So do those need to be updated to handle either connector type? The debugfs code loops over all the connectors for the DRM device and skips those that aren't DisplayPort ones. So fixing this up to properly support multiple instances in the dp_debugfs code as well should resolve this. Regards, Bjorn