From: Peter Zijlstra <peterz@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Yafang Shao <laoar.shao@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the tip tree
Date: Wed, 6 Oct 2021 08:59:31 +0200 [thread overview]
Message-ID: <YV1JU/wOFNn19MP7@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20211006140655.6381bc5d@canb.auug.org.au>
On Wed, Oct 06, 2021 at 02:06:55PM +1100, Stephen Rothwell wrote:
> Hi Peter,
>
> On Mon, 20 Sep 2021 13:18:53 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Mon, Sep 20, 2021 at 11:33:30AM +1000, Stephen Rothwell wrote:
> > >
> > > After merging the tip tree, today's linux-next build (powerpc_ppc64
> > > defconfig) produced this warning:
> > >
> > > kernel/sched/debug.c: In function 'print_cfs_group_stats':
> > > kernel/sched/debug.c:460:41: warning: unused variable 'stats' [-Wunused-variable]
> > > 460 | struct sched_statistics *stats = __schedstats_from_se(se);
> > > | ^~~~~
> >
> > So I've not seen that one *yet*, I've dont a bunch of SCHEDSTAT=n
> > builds. I do think GCC is being quite stupid for giving it, seeing how
> > the whole thing is within if (0). The GCC people seem to disagree when I
> > brought it up.
> >
> > Anyway, what I did in other parts was the below; that seems to 'upgrade'
> > the warnings from -Wunused-variable to -Wunused-but-set-variable, and
> > that latter *is* in W=1, and I'm arguing it should be promoted to W=2 or
> > thereabout.
> >
> > Given that whole if(0) {} thing, I don't feel motivated to change things
> > overly much and quite strongly feel this is the compiler being daft.
> >
> > ---
> >
> > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> > index 935dad7dffb7..ef71de01e4d7 100644
> > --- a/kernel/sched/debug.c
> > +++ b/kernel/sched/debug.c
> > @@ -457,7 +457,8 @@ static void print_cfs_group_stats(struct seq_file *m, int cpu, struct task_group
> > PN(se->sum_exec_runtime);
> >
> > if (schedstat_enabled()) {
> > - struct sched_statistics *stats = __schedstats_from_se(se);
> > + struct sched_statistics *stats;
> > + stats = __schedstats_from_se(se);
> >
> > PN_SCHEDSTAT(wait_start);
> > PN_SCHEDSTAT(sleep_start);
>
> Any progress on this? I am still getting the warning.
Urgh, sorry, fell through cracks. Will commit fixup in a few.
next prev parent reply other threads:[~2021-10-06 7:00 UTC|newest]
Thread overview: 169+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 1:33 linux-next: build warning after merge of the tip tree Stephen Rothwell
2021-09-20 6:55 ` Yafang Shao
2021-09-20 8:30 ` Stephen Rothwell
2021-09-20 8:57 ` Stephen Rothwell
2021-09-20 11:18 ` Peter Zijlstra
2021-10-06 3:06 ` Stephen Rothwell
2021-10-06 6:59 ` Peter Zijlstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-01 0:14 Stephen Rothwell
2024-02-01 5:25 ` Xin Li
2024-02-01 8:59 ` Xin Li
2024-02-01 14:15 ` Borislav Petkov
2023-01-13 1:53 Stephen Rothwell
2022-10-24 0:28 Stephen Rothwell
2022-10-24 8:59 ` Peter Zijlstra
2021-10-28 12:26 Stephen Rothwell
2021-10-28 12:58 ` Borislav Petkov
2021-10-28 15:24 ` Bae, Chang Seok
2021-09-29 5:00 Stephen Rothwell
2021-09-29 7:43 ` Peter Zijlstra
2021-09-21 3:50 Stephen Rothwell
2021-09-17 1:58 Stephen Rothwell
2021-09-17 8:23 ` Peter Zijlstra
2021-09-17 15:58 ` Paul E. McKenney
2021-11-23 5:21 ` Stephen Rothwell
2021-09-20 1:38 ` Stephen Rothwell
2021-10-21 3:03 ` Stephen Rothwell
2021-10-21 8:57 ` Peter Zijlstra
2021-10-21 8:58 ` Juergen Gross
2021-08-13 7:48 Stephen Rothwell
2021-08-13 7:08 Stephen Rothwell
2020-12-14 5:48 Stephen Rothwell
2020-12-14 7:32 ` Ard Biesheuvel
2020-11-05 7:06 Stephen Rothwell
2020-11-06 4:35 ` Stephen Rothwell
2020-10-28 3:23 Stephen Rothwell
2020-11-15 22:17 ` Stephen Rothwell
2020-11-15 22:23 ` Balbir Singh
2020-11-17 5:21 ` Balbir Singh
2020-11-23 7:23 ` Stephen Rothwell
2020-10-08 4:28 Stephen Rothwell
2020-10-08 9:02 ` Borislav Petkov
2020-09-25 9:36 Stephen Rothwell
2020-09-14 3:22 Stephen Rothwell
2020-09-14 20:11 ` Kees Cook
2020-09-14 22:35 ` Stephen Rothwell
2020-10-01 11:02 ` Stephen Rothwell
2020-10-02 22:46 ` Kees Cook
2020-10-03 21:54 ` Kees Cook
2020-10-03 23:24 ` Stephen Rothwell
2020-10-04 7:42 ` Kees Cook
2020-10-04 8:27 ` Kees Cook
2020-10-04 10:00 ` Stephen Rothwell
2020-10-05 2:44 ` Kees Cook
2020-10-14 22:25 ` Stephen Rothwell
2020-10-14 23:10 ` Kees Cook
2020-10-15 0:19 ` Stephen Rothwell
2020-05-21 11:56 Stephen Rothwell
2020-05-19 6:57 Stephen Rothwell
2020-05-19 7:12 ` Steve French
2020-04-28 6:29 Stephen Rothwell
2020-03-30 2:47 Stephen Rothwell
2020-03-31 21:57 ` Stephen Rothwell
2020-04-01 10:25 ` Thomas Gleixner
2020-04-01 22:00 ` Stephen Rothwell
2020-04-01 22:39 ` Thomas Gleixner
2020-04-13 0:01 ` Stephen Rothwell
2020-04-14 8:42 ` Thomas Gleixner
2020-01-20 5:38 Stephen Rothwell
2020-01-20 6:00 ` Viresh Kumar
2020-01-07 5:43 Stephen Rothwell
2020-01-07 7:16 ` Ingo Molnar
2020-01-07 7:22 ` Shile Zhang
2019-07-26 3:05 Stephen Rothwell
2019-07-26 4:49 ` Josh Poimboeuf
2019-07-26 5:49 ` Stephen Rothwell
2018-11-06 0:46 Stephen Rothwell
2018-12-19 0:55 ` Stephen Rothwell
2018-09-11 3:53 Stephen Rothwell
2018-09-12 19:35 ` Thomas Gleixner
2018-03-23 2:28 Stephen Rothwell
2018-03-23 8:31 ` Christoph Hellwig
2018-03-23 9:57 ` Stephen Rothwell
2018-03-16 5:37 Stephen Rothwell
2018-03-16 5:52 ` Dou Liyang
2018-03-16 6:04 ` Dou Liyang
2018-03-16 7:55 ` Thomas Gleixner
2018-01-10 4:41 Stephen Rothwell
2017-09-27 3:42 Stephen Rothwell
2017-09-27 11:50 ` Prarit Bhargava
2017-06-28 7:15 Stephen Rothwell
2017-06-23 3:58 Stephen Rothwell
2017-06-23 4:00 ` Stephen Rothwell
2017-06-23 4:10 ` Michael Ellerman
2017-06-23 4:22 ` Stephen Rothwell
2016-12-14 2:28 Stephen Rothwell
2016-12-14 7:24 ` Ingo Molnar
2016-12-14 8:05 ` Richard Weinberger
2016-12-14 8:26 ` Stephen Rothwell
2016-12-14 8:10 ` Stephen Rothwell
2016-07-24 5:32 Stephen Rothwell
2016-07-25 7:16 ` Thomas Gleixner
2016-07-25 13:11 ` Daniel Lezcano
2016-07-25 14:53 ` Rich Felker
2016-07-25 16:42 ` Mark Brown
2016-07-25 17:54 ` Rich Felker
2016-07-25 14:48 ` Rich Felker
2016-04-07 5:26 Stephen Rothwell
2016-04-07 8:48 ` Ingo Molnar
2016-04-07 12:03 ` Stephen Rothwell
2015-05-12 3:35 Stephen Rothwell
2014-08-05 0:58 Stephen Rothwell
2014-07-18 5:00 Stephen Rothwell
2014-07-18 19:16 ` H. Peter Anvin
2014-07-18 19:57 ` Andy Lutomirski
2014-07-18 20:05 ` H. Peter Anvin
2014-07-18 20:08 ` Andy Lutomirski
2014-07-18 20:15 ` H. Peter Anvin
2014-07-18 20:20 ` Andy Lutomirski
2014-07-18 20:50 ` H. Peter Anvin
2014-06-16 1:57 Stephen Rothwell
2014-06-20 4:24 ` Stephen Rothwell
2014-06-20 4:30 ` H. Peter Anvin
2014-06-20 4:35 ` Stephen Rothwell
2014-03-06 6:12 Stephen Rothwell
2014-02-24 4:17 Stephen Rothwell
2014-02-24 5:56 ` Stephen Rothwell
2014-02-24 6:12 ` Andrew Morton
2014-02-24 6:23 ` Stephen Rothwell
2014-02-24 15:48 ` Andi Kleen
2014-02-24 15:51 ` H. Peter Anvin
2014-03-06 4:00 ` Stephen Rothwell
2014-03-28 5:52 ` Stephen Rothwell
2014-03-31 9:45 ` Thomas Gleixner
2014-03-31 10:57 ` Stephen Rothwell
2014-04-01 0:26 ` Stephen Rothwell
2014-04-01 1:56 ` H. Peter Anvin
2013-08-19 4:26 Stephen Rothwell
2013-08-19 6:58 ` Ingo Molnar
2013-08-20 0:52 ` Andi Kleen
2013-08-20 6:42 ` Ingo Molnar
2013-08-30 8:55 ` Stephen Rothwell
2013-08-30 20:42 ` Andi Kleen
2013-08-31 6:41 ` Ingo Molnar
2013-02-02 5:58 Stephen Rothwell
2013-02-02 5:55 Stephen Rothwell
2013-02-02 5:51 Stephen Rothwell
2013-01-30 11:41 Stephen Rothwell
2012-10-01 14:54 Stephen Rothwell
2012-10-01 16:10 ` Josh Triplett
2012-09-27 7:46 Stephen Rothwell
2011-09-14 6:34 Stephen Rothwell
2011-09-14 7:49 ` Yong Zhang
2011-09-14 9:37 ` Thomas Gleixner
2011-09-14 9:43 ` Shan Hai
2011-09-14 6:22 Stephen Rothwell
2010-11-29 1:11 Stephen Rothwell
2010-09-03 2:10 Stephen Rothwell
2010-09-03 2:12 ` Stephen Rothwell
2010-09-03 9:04 ` Wu Fengguang
2010-09-03 10:07 ` Haicheng Li
2010-05-17 5:58 Stephen Rothwell
2010-03-17 3:57 Stephen Rothwell
2010-03-17 4:00 ` KOSAKI Motohiro
2010-03-17 4:52 ` Stephen Rothwell
2010-03-17 7:02 ` Ingo Molnar
2010-03-17 8:02 ` KOSAKI Motohiro
2010-02-23 5:01 Stephen Rothwell
2010-02-23 8:52 ` Yinghai Lu
2010-02-23 10:43 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV1JU/wOFNn19MP7@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).