From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27D6FC433EF for ; Wed, 6 Oct 2021 16:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BDC261166 for ; Wed, 6 Oct 2021 16:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239337AbhJFQQ2 (ORCPT ); Wed, 6 Oct 2021 12:16:28 -0400 Received: from mga04.intel.com ([192.55.52.120]:65111 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbhJFQQ1 (ORCPT ); Wed, 6 Oct 2021 12:16:27 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="224805572" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="224805572" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:14:33 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="439948775" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:14:29 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mY9Yo-009Fg0-5T; Wed, 06 Oct 2021 19:14:26 +0300 Date: Wed, 6 Oct 2021 19:14:26 +0300 From: Andy Shevchenko To: Lu Baolu Cc: Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, David Woodhouse , Joerg Roedel , Will Deacon Subject: Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file Message-ID: References: <20210729163538.40101-1-andriy.shevchenko@linux.intel.com> <3c7663db-5b1e-3e00-3ff1-381c7a107ac9@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c7663db-5b1e-3e00-3ff1-381c7a107ac9@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: > Hi Andy, > > On 7/30/21 12:35 AM, Andy Shevchenko wrote: > > Compiler is not happy about hidden declaration of intel_iommu_ops. > > > > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' was not declared. Should it be static? > > > > Move declaration to header file to make compiler happy. > > Thanks for the cleanup. Sharing data structures between different files > doesn't seem to be a good design. How about adding a helper so that the > intel_iommu_ops could be a static one? I don't see any change in the upstream. What's the plan? Can we take my patch as a quick fix? -- With Best Regards, Andy Shevchenko