From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE55AC433EF for ; Thu, 7 Oct 2021 10:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97E0960C4C for ; Thu, 7 Oct 2021 10:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240971AbhJGKkb (ORCPT ); Thu, 7 Oct 2021 06:40:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240949AbhJGKkQ (ORCPT ); Thu, 7 Oct 2021 06:40:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F57B60F02; Thu, 7 Oct 2021 10:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633603103; bh=lu5k2LNYph7kGX6NH429bKjPjz5kZlIuiNVBrGopjRg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FsJkGVtPNbgrwogrOSdK+rN2seu5yj1PE4+u2NIGUe5Y3/9JbaMTJz+bEFD31/K5e VhntWSLtGP2rsc0Pt4o9ElpUJeaQKTCb4rFwYqoEpa2kbjdYMVddcfo1XRKjK/CLFv 5KVQuX2l22s/RDZ4jnmVjdTTNmlAk+fn75hmueY0= Date: Thu, 7 Oct 2021 12:38:21 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Peter Zijlstra , Thomas Gleixner , Randy Dunlap , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, netdev@vger.kernel.org, Brendan Higgins , "Rafael J. Wysocki" , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Thomas Graf , Herbert Xu , Andrew Morton Subject: Re: [PATCH v2 2/4] kernel.h: Split out container_of() and typeof_member() macros Message-ID: References: <20211007095129.22037-1-andriy.shevchenko@linux.intel.com> <20211007095129.22037-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211007095129.22037-3-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 12:51:27PM +0300, Andy Shevchenko wrote: > --- a/lib/radix-tree.c > +++ b/lib/radix-tree.c > @@ -12,19 +12,21 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > #include > -#include > #include > +#include > #include > #include /* in_interrupt() */ > #include > #include > #include > #include > +#include > #include > > /* > @@ -285,6 +287,8 @@ radix_tree_node_alloc(gfp_t gfp_mask, struct radix_tree_node *parent, > return ret; > } > > +extern void radix_tree_node_rcu_free(struct rcu_head *head); .c files should not need an extern, this belongs in a .h file somewhere, or something really went wrong here... thanks, greg k-h