From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC30C433FE for ; Thu, 7 Oct 2021 17:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75B55603E9 for ; Thu, 7 Oct 2021 17:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242402AbhJGRbc (ORCPT ); Thu, 7 Oct 2021 13:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242307AbhJGRb1 (ORCPT ); Thu, 7 Oct 2021 13:31:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51E45C061570; Thu, 7 Oct 2021 10:29:33 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C3871DDE; Thu, 7 Oct 2021 19:29:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1633627771; bh=bX70RVpHqIP8+Slj+fBenki+5BKZhXbz2i1z5b0/GWE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B0LEwZQzwy4hLNE0zUPdQLPkr/DTU58lDjcHQnHI52JCbs6oqbVyjW1fy61uUtbHf BBsBUAisiJNxEqpa/EJGNvIke/rGoyYgIuZMi/NHpSueKJrtPcF/vB+hW0iqT0Er+Q w1yu6wNKyqz+9QXqJ1nGr49pQjzqDTHPbgCp/g3o= Date: Thu, 7 Oct 2021 20:29:21 +0300 From: Laurent Pinchart To: Jonathan Cameron Cc: Andy Shevchenko , Brendan Higgins , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Mauro Carvalho Chehab , Andrew Morton , Miguel Ojeda , linux@rasmusvillemoes.dk, Thorsten Leemhuis Subject: Re: [PATCH v4 4/7] list.h: Replace kernel.h with the necessary inclusions Message-ID: References: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com> <20211007154407.29746-5-andriy.shevchenko@linux.intel.com> <20211007171635.2f161739@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211007171635.2f161739@jic23-huawei> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 05:16:35PM +0100, Jonathan Cameron wrote: > On Thu, 7 Oct 2021 18:44:04 +0300 Andy Shevchenko wrote: > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > Signed-off-by: Andy Shevchenko > > --- > > include/linux/list.h | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/list.h b/include/linux/list.h > > index f2af4b4aa4e9..5dc679b373da 100644 > > --- a/include/linux/list.h > > +++ b/include/linux/list.h > > @@ -2,11 +2,13 @@ > > #ifndef _LINUX_LIST_H > > #define _LINUX_LIST_H > > > > +#include > > +#include > > #include > > #include > > #include > > Is there a reason you didn't quite sort this into alphabetical order? On a side note, if someone with perle knowledge could add a checkpatch warning for this, I think it would be very nice. I'm a bit tired of asking for alphabetical order in reviews :-) > > -#include > > -#include > > + > > +#include > > > > /* > > * Circular doubly linked list implementation. -- Regards, Laurent Pinchart