From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: Optimise put_pages_list()
Date: Thu, 7 Oct 2021 21:55:21 +0100 [thread overview]
Message-ID: <YV9eueky+lBfSWA3@casper.infradead.org> (raw)
In-Reply-To: <20211007123109.6a49c7c625e414acf7546c89@linux-foundation.org>
On Thu, Oct 07, 2021 at 12:31:09PM -0700, Andrew Morton wrote:
> On Thu, 7 Oct 2021 20:21:37 +0100 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
>
> > Instead of calling put_page() one page at a time, pop pages off
> > the list if their refcount was too high and pass the remainder to
> > put_unref_page_list(). This should be a speed improvement, but I have
> > no measurements to support that. Current callers do not care about
> > performance, but I hope to add some which do.
>
> Don't you think it would actually be slower to take an additional pass
> across the list? If the list is long enough to cause cache thrashing.
> Maybe it's faster for small lists.
My first response is an appeal to authority -- release_pages() does
this same thing. Only it takes an array, constructs a list and passes
that to put_unref_page_list(). So if that's slower (and lists _are_
slower than arrays), we should have a put_unref_page_array().
Second, we can follow through the code paths and reason about it.
Before:
while (!list_empty(pages)) {
put_page(victim);
page = compound_head(page);
if (put_page_testzero(page))
__put_page(page);
__put_single_page(page)
__page_cache_release(page);
mem_cgroup_uncharge(page);
<---
free_unref_page(page, 0);
free_unref_page_prepare()
local_lock_irqsave(&pagesets.lock, flags);
free_unref_page_commit(page, pfn, migratetype, order);
local_unlock_irqrestore(&pagesets.lock, flags);
After:
free_unref_page_list(pages);
list_for_each_entry_safe(page, next, list, lru) {
if (!free_unref_page_prepare(page, pfn, 0)) {
}
local_lock_irqsave(&pagesets.lock, flags);
list_for_each_entry_safe(page, next, list, lru) {
free_unref_page_commit()
}
local_unlock_irqrestore(&pagesets.lock, flags);
So the major win here is that we disable/enable interrupts once per
batch rather than once per page.
next prev parent reply other threads:[~2021-10-07 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 19:21 [PATCH v2] mm: Optimise put_pages_list() Matthew Wilcox (Oracle)
2021-10-07 19:31 ` Andrew Morton
2021-10-07 20:55 ` Matthew Wilcox [this message]
2021-10-07 23:35 ` Andrew Morton
2021-10-08 14:17 ` Matthew Wilcox
2021-10-20 22:07 ` Anthony Yznaga
2021-10-21 14:41 ` Joao Martins
2021-10-22 23:26 ` Anthony Yznaga
2021-10-23 1:13 ` Matthew Wilcox
2021-10-23 6:11 ` Anthony Yznaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV9eueky+lBfSWA3@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).