Re: [PATCH v4 net-next 01/10] dt-bindings: net: dsa: dt bindings for microchip lan937x

From: Andrew Lunn <andrew@lunn.ch>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: netdev@vger.kernel.org, olteanv@gmail.com, robh+dt@kernel.org,
	UNGLinuxDriver@microchip.com, Woojung.Huh@microchip.com,
	hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	vivien.didelot@gmail.com, f.fainelli@gmail.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 net-next 01/10] dt-bindings: net: dsa: dt bindings for microchip lan937x
Date: Thu, 7 Oct 2021 23:41:39 +0200	[thread overview]
Message-ID: <YV9pk13TT9W7X2i1@lunn.ch> (raw)
In-Reply-To: <20211007151200.748944-2-prasanna.vengateshan@microchip.com>

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    //Ethernet switch connected via spi to the host
> +    ethernet {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      fixed-link {
> +        speed = <1000>;
> +        full-duplex;
> +      };
> +    };
> +
> +    spi {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      lan9374: switch@0 {
> +        compatible = "microchip,lan9374";
> +        reg = <0>;
> +
> +        spi-max-frequency = <44000000>;
> +
> +        ethernet-ports {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +          port@0 {
> +            reg = <0>;
> +            label = "lan1";
> +            phy-mode = "internal";
> +            phy-handle = <&t1phy0>;
> +          };

...

> +        mdio {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          t1phy0: ethernet-phy@0{
> +            reg = <0x0>;
> +          };

Does this pass Rob's DT schema proof tools? You don't have any
description of the mdio properties.

Maybe look at nxp,sja1105.yaml

      Andrew