From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8364CC433FE for ; Tue, 28 Sep 2021 00:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6610F61181 for ; Tue, 28 Sep 2021 00:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238261AbhI1AFk (ORCPT ); Mon, 27 Sep 2021 20:05:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238236AbhI1AFj (ORCPT ); Mon, 27 Sep 2021 20:05:39 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04637C061604 for ; Mon, 27 Sep 2021 17:04:00 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id b20so85163412lfv.3 for ; Mon, 27 Sep 2021 17:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9bL4iRqqm89pRQSEPivN/gaNctu5ZJkCkeOF8HtDooE=; b=BWGbHDT8WDVjiSuAKlE1lEDV/8IaADOQhOuH9iOm3Fb5MPNa9fL6CHku/manoKLIJU rraEp263CPdPlBzWb8rh9TpXI2OBj/+NTKT87H0QnEWiUcb7zuxJJpKVx1YzbnmyWjFA Eqvg7Rd/ylGsa1bXpXdVAIfNt4TbkmKiG3Ld0g4UL0ZbHJHw7B7sOO44BlDnIhAawH84 8gWgDFT69Twb+xZClYc0LXHOaazrkaq1MVot4wq9JcNWI/M7UkoeGILUYNhdQLL0/MVl her38/c5QTcUMXh5jepwpqSZiZvHbb8HUQrup8BuOY81QataUC1Kb0+C3RdIwR92GW2d sy2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9bL4iRqqm89pRQSEPivN/gaNctu5ZJkCkeOF8HtDooE=; b=iNUYfE1VVgl/d3+SijpoTBmU0kS8cNSr8OiUUhamrVXRN3FPqB3NdgxH7Xw4n6/PW2 +5SmnqovSebG9IwYOtoUjWUPf65KHm3dnDJ+kM9CpGmR1eenPJlMuZwl41NKQFV7DifF 2wBaTos25Gv51kF3aud8nOgwSrfeTeneaUoNWnB+Z5EOUxFJIATGZDL2eY9X4YM0mZYg TsDVlYJr7lFO6V2r8+5d/7spXhrWuUIi3z4diQaf0Cq9HBVmfhXi1ZOIp3UU6yFfox4T ddPn57m3YrNlDteU+egvltFwT1KxuVuEWQlTgAOG9L7a1HXRFUGcV4/yRwMmgF2RPTMc g15Q== X-Gm-Message-State: AOAM531xjmFvyO8FuH+v/FxBT2ogSWBT/TSvnbHajS9kFcL8vxa8ekCZ ssOxqtw0B/evhueQCa9DTnlycQ== X-Google-Smtp-Source: ABdhPJx1XQfmZA36FtlL4UskEKqlHfdZJLZFI4pV/dsoUKSvihRwWpAfv39/56vOGjFCEbfkEIk5xg== X-Received: by 2002:a05:6512:3191:: with SMTP id i17mr2482707lfe.381.1632787438343; Mon, 27 Sep 2021 17:03:58 -0700 (PDT) Received: from localhost (h-46-59-88-219.A463.priv.bahnhof.se. [46.59.88.219]) by smtp.gmail.com with ESMTPSA id b22sm1741542lfv.286.2021.09.27.17.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 17:03:57 -0700 (PDT) Date: Tue, 28 Sep 2021 02:03:56 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Nikita Yushchenko Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Barinov Subject: Re: [PATCH v2] media: rcar-vin: add G/S_PARM ioctls Message-ID: References: <20210924135138.29950-1-nikita.yoush@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210924135138.29950-1-nikita.yoush@cogentembedded.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Nikita and Vladimir, Thanks for your work. On 2021-09-24 16:51:38 +0300, Nikita Yushchenko wrote: > From: Vladimir Barinov > > This adds g/s_parm ioctls for parallel interface. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Nikita Yushchenko Reviewed-by: Niklas Söderlund > --- > Changes from v1: > - use &vin->vdev to access vin's struct video_device > > drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c > index bdeff51bf768..a5bfa76fdac6 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -527,6 +527,24 @@ static int rvin_s_selection(struct file *file, void *fh, > return 0; > } > > +static int rvin_g_parm(struct file *file, void *priv, > + struct v4l2_streamparm *parm) > +{ > + struct rvin_dev *vin = video_drvdata(file); > + struct v4l2_subdev *sd = vin_to_source(vin); > + > + return v4l2_g_parm_cap(&vin->vdev, sd, parm); > +} > + > +static int rvin_s_parm(struct file *file, void *priv, > + struct v4l2_streamparm *parm) > +{ > + struct rvin_dev *vin = video_drvdata(file); > + struct v4l2_subdev *sd = vin_to_source(vin); > + > + return v4l2_s_parm_cap(&vin->vdev, sd, parm); > +} > + > static int rvin_g_pixelaspect(struct file *file, void *priv, > int type, struct v4l2_fract *f) > { > @@ -743,6 +761,9 @@ static const struct v4l2_ioctl_ops rvin_ioctl_ops = { > .vidioc_g_selection = rvin_g_selection, > .vidioc_s_selection = rvin_s_selection, > > + .vidioc_g_parm = rvin_g_parm, > + .vidioc_s_parm = rvin_s_parm, > + > .vidioc_g_pixelaspect = rvin_g_pixelaspect, > > .vidioc_enum_input = rvin_enum_input, > -- > 2.30.2 > -- Regards, Niklas Söderlund