From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: linusw@kernel.org, kaloz@openwrt.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: intel-ixp42x-welltech-epbx100 no longer boot due to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")
Date: Tue, 28 Sep 2021 13:38:53 +0200 [thread overview]
Message-ID: <YVL+zd33DwmLXo6B@Red> (raw)
In-Reply-To: <m3r1d9ng7m.fsf@t19.piap.pl>
Le Tue, Sep 28, 2021 at 12:32:13PM +0200, Krzysztof Hałasa a écrit :
> Hello Corentin,
>
> Corentin Labbe <clabbe.montjoie@gmail.com> writes:
>
> > I am working on puting my ixp4xx board on kernelCI.
> > But it no longer boot since 4.14.
> > It only prints "Starting kernelUncompressing Linux... done, booting the kernel." then nothing.
> >
> > I bisected the break to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")
>
> I guess you build your kernel as big-endian.
Hello
Yes, IXP4XX is by default BE.
>
> These parts seem suspicious to me:
>
> - str r8, [r5] @ Save physical start of kernel
> +#ifdef CONFIG_CPU_ENDIAN_BE8
> + str r8, [r5, #4] @ Save physical start of kernel (BE)
> +#else
> + str r8, [r5] @ Save physical start of kernel (LE)
> +#endif
>
> and
>
> - str r3, [r5] @ Save physical end of kernel
> +#ifdef CONFIG_CPU_ENDIAN_BE8
> + str r3, [r5, #4] @ Save physical end of kernel (BE)
> +#else
> + str r3, [r5] @ Save physical end of kernel (LE)
> +#endif
>
> IXP4xx, being ARMv5, uses CONFIG_CPU_ENDIAN_BE32 (when configured as
> BE), but it needs the ", #4" as well.
>
> I'd test with: #if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDIAN_BE32
Thanks, with the following patch, my boards boots
diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
index 29070eb8df7d..3fc7f9750ce4 100644
--- a/arch/arm/kernel/head.S
+++ b/arch/arm/kernel/head.S
@@ -253,7 +253,7 @@ __create_page_tables:
add r0, r4, #KERNEL_OFFSET >> (SECTION_SHIFT - PMD_ORDER)
ldr r6, =(_end - 1)
adr_l r5, kernel_sec_start @ _pa(kernel_sec_start)
-#ifdef CONFIG_CPU_ENDIAN_BE8
+#if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDIAN_BE32
str r8, [r5, #4] @ Save physical start of kernel (BE)
#else
str r8, [r5] @ Save physical start of kernel (LE)
@@ -266,7 +266,7 @@ __create_page_tables:
bls 1b
eor r3, r3, r7 @ Remove the MMU flags
adr_l r5, kernel_sec_end @ _pa(kernel_sec_end)
-#ifdef CONFIG_CPU_ENDIAN_BE8
+#if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDIAN_BE32
str r3, [r5, #4] @ Save physical end of kernel (BE)
#else
str r3, [r5] @ Save physical end of kernel (LE)
Regards
prev parent reply other threads:[~2021-09-28 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 7:27 intel-ixp42x-welltech-epbx100 no longer boot due to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression") Corentin Labbe
2021-09-28 10:32 ` Krzysztof Hałasa
2021-09-28 11:38 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVL+zd33DwmLXo6B@Red \
--to=clabbe.montjoie@gmail.com \
--cc=kaloz@openwrt.org \
--cc=khalasa@piap.pl \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).