From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 1/2] PCI: Use software node API with additional device properties
Date: Thu, 30 Sep 2021 14:26:32 +0300 [thread overview]
Message-ID: <YVWe6A3TKz5LXNNb@kuha.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gAfWaUXjMrSf7Ei-P=0u7kzHVKQNFY0aSxs6KFd5T6ow@mail.gmail.com>
On Thu, Sep 30, 2021 at 12:37:27PM +0200, Rafael J. Wysocki wrote:
> On Thu, Sep 30, 2021 at 12:20 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Thu, Sep 30, 2021 at 1:06 PM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > > On Thu, Sep 30, 2021 at 10:33:27AM +0800, Zhangfei Gao wrote:
> >
> > ...
> >
> > > If the device is really never removed, then we could also constify the
> > > node and the properties in it. Then the patch would look like this:
> >
> > I'm not sure the user can't force removal of the device (via PCI
> > rescan, for example,, or via unbind/bind cycle).
>
> The sysfs unbind doesn't remove the device, though, AFAICS. It just
> unbinds the driver from it, if any.
>
> > I guess this way should be really taken carefully.
>
> But I agree.
OK. Makes sense.
Thanks guys,
--
heikki
next prev parent reply other threads:[~2021-09-30 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:37 [PATCH 0/2] device property: Remove device_add_properties() Heikki Krogerus
2021-09-29 13:37 ` [PATCH 1/2] PCI: Use software node API with additional device properties Heikki Krogerus
2021-09-29 17:08 ` Bjorn Helgaas
2021-09-30 2:33 ` Zhangfei Gao
2021-09-30 10:05 ` Heikki Krogerus
2021-09-30 10:19 ` Andy Shevchenko
2021-09-30 10:37 ` Rafael J. Wysocki
2021-09-30 11:26 ` Heikki Krogerus [this message]
2021-09-29 13:37 ` [PATCH 2/2] device property: Remove device_add_properties() API Heikki Krogerus
2021-09-29 15:44 ` [PATCH 0/2] device property: Remove device_add_properties() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVWe6A3TKz5LXNNb@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).