From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sandeep Maheswaram <sanm@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Pratham Pratap <prathampratap@codeaurora.org>
Subject: Re: [PATCH 1/3] dt-bindings: usb: qcom,dwc3: Add multi-pd bindings for dwc3 qcom
Date: Thu, 30 Sep 2021 09:07:20 -0700 [thread overview]
Message-ID: <YVXguCSrsdMoCCXH@ripper> (raw)
In-Reply-To: <e947695b-cd50-391b-3de9-3c028dbddab2@codeaurora.org>
On Thu 30 Sep 02:41 PDT 2021, Sandeep Maheswaram wrote:
>
> On 9/7/2021 7:20 PM, Bjorn Andersson wrote:
> > On Mon 30 Aug 10:54 PDT 2021, Sandeep Maheswaram wrote:
> >
> > > Add multi pd bindings to set performance state for cx domain
> > > to maintain minimum corner voltage for USB clocks.
> > >
> > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> > > ---
> > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 13 ++++++++++++-
> > > 1 file changed, 12 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > > index e70afc4..838d9c4 100644
> > > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > > @@ -41,7 +41,18 @@ properties:
> > > power-domains:
> > > description: specifies a phandle to PM domain provider node
> > > - maxItems: 1
> > > + minItems: 1
> > > + items:
> > > + - description: optional,cx power domain
> > > + - description: USB gdsc power domain
> > > +
> > > + power-domain-names:
> > > + items:
> > > + - const: cx
> > > + - const: usb_gdsc
> > But "usb_gdsc" is a subdomain of "cx", why can't we describe this fact
> > in gcc?
> >
> > Regards,
> > Bjorn
> Thanks for your review.
> Any idea on how can this be described in gcc ? Can you point any reference
> for this .
>
There's a series from Dmitry that defines such a relationship between
MDSS_GDSC and the MMCX domain on SM8250. This seems like a continuation
of that support, given that we have multiple parent domains (cx, mx
etc).
You can find that discussion here:
https://lore.kernel.org/all/20210727202004.712665-1-dmitry.baryshkov@linaro.org/
Regards,
Bjorn
> Regards
> Sandeep
> > > +
> > > + required-opps:
> > > + description: specifies the performance state to cx power domain
> > > clocks:
> > > description:
> > > --
> > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> > > of Code Aurora Forum, hosted by The Linux Foundation
> > >
next prev parent reply other threads:[~2021-09-30 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 17:54 [PATCH 0/3] USB DWC3 QCOM Multi power domain support Sandeep Maheswaram
2021-08-30 17:54 ` [PATCH 1/3] dt-bindings: usb: qcom,dwc3: Add multi-pd bindings for dwc3 qcom Sandeep Maheswaram
2021-08-30 20:07 ` Doug Anderson
2021-09-06 9:15 ` Sandeep Maheswaram
2021-09-07 12:19 ` Rajendra Nayak
2021-09-07 13:50 ` Bjorn Andersson
[not found] ` <e947695b-cd50-391b-3de9-3c028dbddab2@codeaurora.org>
2021-09-30 16:07 ` Bjorn Andersson [this message]
2021-08-30 17:54 ` [PATCH 2/3] usb: dwc3: qcom: Add multi-pd support Sandeep Maheswaram
2021-08-31 5:34 ` Felipe Balbi
2021-08-30 17:54 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add cx power domain support Sandeep Maheswaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVXguCSrsdMoCCXH@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=prathampratap@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).