From: Vinod Koul <vkoul@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Jami Kettunen <jamipkettunen@gmail.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Add missing vdd-supply for QUSB2 PHY
Date: Fri, 1 Oct 2021 13:46:23 +0530 [thread overview]
Message-ID: <YVbD12kTfbGmRYId@matsya> (raw)
In-Reply-To: <20210928022002.26286-1-shawn.guo@linaro.org>
Hi Shawn,
On 28-09-21, 10:19, Shawn Guo wrote:
> The series adds missing vdd-supply for QUSB2 PHY which is required for
> digital circuit. The driver works right now likely because firmware
> already sets it up. Add it to bindings, driver and DTS that miss the
> supply.
>
> It should not cause problem for existing DTBs:
> - SC7180, SDM630, SDM845 based platforms already specified vdd-supply
> in the DTBs.
> - MSM8996 and MSM8998 platform DTBs miss vdd-supply, but dummy regulator
> will ensure QUSB2 PHY driver works as before on these platforms.
What about the rest.. I checked SM8350 and SM8250 mtp ones are missing
this. With the property made mandatory, I guess it would cause these to
fail right..
>
> Changes for v2:
> - Correct copy & paste error on vdd-supply name in bindings doc.
>
>
> Shawn Guo (3):
> dt-bindings: phy: qcom,qusb2: Add missing vdd-supply
> phy: qcom-qusb2: Add missing vdd supply
> arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY
>
> Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++++++
> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone.dtsi | 1 +
> arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 1 +
> arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 1 +
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +-
> 6 files changed, 12 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
--
~Vinod
next prev parent reply other threads:[~2021-10-01 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 2:19 [PATCH v2 0/3] Add missing vdd-supply for QUSB2 PHY Shawn Guo
2021-09-28 2:20 ` [PATCH v2 1/3] dt-bindings: phy: qcom,qusb2: Add missing vdd-supply Shawn Guo
2021-10-04 18:24 ` Rob Herring
2021-09-28 2:20 ` [PATCH v2 2/3] phy: qcom-qusb2: Add missing vdd supply Shawn Guo
2021-09-28 2:20 ` [PATCH v2 3/3] arm64: dts: qcom: Add missing vdd-supply for QUSB2 PHY Shawn Guo
2021-10-05 7:49 ` Vinod Koul
2021-11-20 23:55 ` (subset) " Bjorn Andersson
2021-10-01 8:16 ` Vinod Koul [this message]
2021-10-04 3:01 ` [PATCH v2 0/3] " Shawn Guo
2021-10-05 7:47 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVbD12kTfbGmRYId@matsya \
--to=vkoul@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@gmail.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).