From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8C8C433F5 for ; Fri, 1 Oct 2021 14:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69E08613A6 for ; Fri, 1 Oct 2021 14:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354695AbhJAO7y (ORCPT ); Fri, 1 Oct 2021 10:59:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231712AbhJAO7v (ORCPT ); Fri, 1 Oct 2021 10:59:51 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 291B1C061775; Fri, 1 Oct 2021 07:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cAWxL3kxMyky/ALcvxBRTl/qlVsp3X+zi1jV2TnUcZY=; b=L8YWA7K9qHLJC/inWvwTS/qXgm 9YpTsKs7ovmD9nmpOtQK0AfwCa27mMlTsC7dcymqZAGOExmps8qArfcN1jWooapBZWdlrqK7lk9F1 s8lEiIMY44GqWQfICclrQwW4XZXacwEljWlHsoSw4iFaN3joqrzPzYkcZhQRe7IkBs1JouTMa94IY fcPDZi1nDcBrfZFJSGlJhLKk6/aj82BM64nGbDujdPJlgJt80Jo7MdRY5Op1+gLQJb5C8jn0YrB38 VE/q3TdXSh4O80AV1QBlUkZEnNQu/n7p7iCmQu5e+UI7zJbMd9CxZJAuZGjqa7YIAu0o0AJ+uIhzC rMShDpQQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWJyZ-007BaB-BH; Fri, 01 Oct 2021 14:57:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 446DB30214E; Fri, 1 Oct 2021 16:57:23 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 33A10265BC20A; Fri, 1 Oct 2021 16:57:23 +0200 (CEST) Date: Fri, 1 Oct 2021 16:57:23 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: Barry Song <21cnbao@gmail.com>, Dietmar Eggemann , LKML , Ingo Molnar , Aubrey Li , Borislav Petkov , Daniel Bristot de Oliveira , Ben Segall , Catalin Marinas , Greg Kroah-Hartman , Guodong Xu , "H. Peter Anvin" , Jonathan Cameron , Juri Lelli , "Cc: Len Brown" , ACPI Devel Maling List , LAK , Linuxarm , Mark Rutland , Mel Gorman , msys.mizuma@gmail.com, "Zengtao (B)" , "Rafael J. Wysocki" , Steven Rostedt , Barry Song , Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Tim Chen , Valentin Schneider , Will Deacon , x86 , yangyicong Subject: Re: [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Message-ID: References: <20210924085104.44806-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 12:39:56PM +0200, Vincent Guittot wrote: > Hi Barry, > > On Fri, 1 Oct 2021 at 12:32, Barry Song <21cnbao@gmail.com> wrote: > > > > Hi Vincent, Dietmar, Peter, Ingo, > > Do you have any comment on this first series which exposes cluster topology > > of ARM64 kunpeng 920 & x86 Jacobsville and supports load balance only for > > the 1st stage? > > I will be very grateful for your comments so that things can move forward in the > > right direction. I think Tim also looks forward to bringing up cluster > > support in > > Jacobsville. > > This patchset makes sense to me and the addition of a new scheduling > level to better reflect the HW topology goes in the right direction. So I had a look, dreading the selecti-idle-sibling changes, and was pleasantly surprised they're gone :-) As is, this does indeed look like something mergable without too much hassle. The one questino I have is, do we want default y? The one nit I have is the Kconfig text, I'm not really sure that's clarifying what a cluster is.