From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Suman Anna <s-anna@ti.com>,
Sinthu Raja <sinthu.raja@ti.com>, Hari Nagalla <hnagalla@ti.com>,
Sinthu Raja <sinthu.raja@mistralsolutions.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles
Date: Mon, 4 Oct 2021 12:54:07 -0500 [thread overview]
Message-ID: <YVs/v7g8wwLq/ujb@robh.at.kernel.org> (raw)
In-Reply-To: <20210925201430.11678-3-nm@ti.com>
On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> just state SoC compatibles without specific board specific compatibles
> aligned with what we have done for J721E/J7200 platforms as well.
This is the wrong direction IMO. Why do you want this other than
alignment?
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Motivation to introduce in V2:
> * Retain consistency with both "soc only" and "board specific" as two
> schemes we support across k3.
>
> V1: did'nt exist
>
> .../devicetree/bindings/arm/ti/k3.yaml | 23 +++++++++++--------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index cefb06424a4a..30c3f5c70014 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -20,12 +20,15 @@ properties:
> oneOf:
>
> - description: K3 AM654 SoC
> - items:
> - - enum:
> - - ti,am654-evm
> - - siemens,iot2050-basic
> - - siemens,iot2050-advanced
> + oneOf:
> - const: ti,am654
> + - items:
> + - enum:
> + - ti,am654-evm
> + - siemens,iot2050-basic
> + - siemens,iot2050-advanced
> + - const: ti,am654
> +
>
> - description: K3 J721E SoC
> oneOf:
> @@ -44,11 +47,13 @@ properties:
> - const: ti,j7200
>
> - description: K3 AM642 SoC
> - items:
> - - enum:
> - - ti,am642-evm
> - - ti,am642-sk
> + oneOf:
> - const: ti,am642
> + - items:
> + - enum:
> + - ti,am642-evm
> + - ti,am642-sk
> + - const: ti,am642
>
> additionalProperties: true
>
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2021-10-04 17:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 20:14 [PATCH V2 0/4] arm64: dts: ti: k3-j721e/j7200: Introduce EVM compatible Nishanth Menon
2021-09-25 20:14 ` [PATCH V2 1/4] dt-bindings: arm: ti: Add missing compatibles for j721e/j7200 evms Nishanth Menon
2021-09-27 14:24 ` Suman Anna
2021-10-04 17:52 ` Rob Herring
2021-09-25 20:14 ` [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles Nishanth Menon
2021-09-27 14:26 ` Suman Anna
2021-10-04 17:54 ` Rob Herring [this message]
2021-10-04 18:59 ` Nishanth Menon
2021-10-05 18:31 ` Nishanth Menon
2021-09-25 20:14 ` [PATCH V2 3/4] arm64: dts: ti: k3-j721e-common-proc-board: Add j721e-evm compatible Nishanth Menon
2021-09-27 14:27 ` Suman Anna
2021-09-25 20:14 ` [PATCH V2 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Add j7200-evm compatible Nishanth Menon
2021-09-27 14:27 ` Suman Anna
2021-10-05 22:56 ` (subset) [PATCH V2 0/4] arm64: dts: ti: k3-j721e/j7200: Introduce EVM compatible Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVs/v7g8wwLq/ujb@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-anna@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).