From: Rob Herring <robh@kernel.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-staging@lists.linux.dev, john@phrozen.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
neil@brown.name, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt: bindings: add ralink RT2880 resets device tree binding documentation
Date: Mon, 4 Oct 2021 13:06:44 -0500 [thread overview]
Message-ID: <YVtCtGcLjNcO2NJ0@robh.at.kernel.org> (raw)
In-Reply-To: <20210926145931.14603-3-sergio.paracuellos@gmail.com>
On Sun, Sep 26, 2021 at 04:59:30PM +0200, Sergio Paracuellos wrote:
> Adds device tree binding documentation for resets in the ralink RT2880 SoCs.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> .../bindings/reset/ralink,rt2880-reset.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml b/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml
> new file mode 100644
> index 000000000000..88eddeb4ee45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/ralink,rt2880-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ralink RT2880 Reset Controller Device Tree Bindings
> +
> +maintainers:
> + - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> +
> +description: |
> + Ralink RT2880 reset controller driver which supports the SoC
> + system controller supplied reset registers for the various peripherals
> + of the SoC.
> +
> + See also:
> + - dt-bindings/reset/ralink-rt2880.h
> +
> +properties:
> + compatible:
> + const: ralink,rt2880-reset
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - '#reset-cells'
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/reset/ralink-rt2880.h>
> + rstctrl: reset-controller {
> + compatible = "ralink,rt2880-reset";
> + #reset-cells = <1>;
How is this h/w controlled? If this is part of a system controller, then
it needs to be documented as such. IOW, you need to document the binding
for the whole block.
Do you really need a child node here? All you need to make a system
controller a reset provider is add '#reset-cells' to it.
Rob
next prev parent reply other threads:[~2021-10-04 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 14:59 [PATCH 0/3] staging: mt7621-dts: complete reset missing stuff Sergio Paracuellos
2021-09-26 14:59 ` [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets Sergio Paracuellos
2021-10-04 18:02 ` Rob Herring
2021-10-04 18:26 ` Sergio Paracuellos
2021-10-05 13:29 ` Rob Herring
2021-10-05 14:28 ` Sergio Paracuellos
2021-09-26 14:59 ` [PATCH 2/3] dt: bindings: add ralink RT2880 resets device tree binding documentation Sergio Paracuellos
2021-10-04 18:06 ` Rob Herring [this message]
2021-10-04 18:23 ` Sergio Paracuellos
2021-10-05 13:27 ` Rob Herring
2021-10-05 14:24 ` Sergio Paracuellos
2021-09-26 14:59 ` [PATCH 3/3] staging: mt7621-dts: align resets with " Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVtCtGcLjNcO2NJ0@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=neil@brown.name \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).