From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C846C433FE for ; Tue, 5 Oct 2021 01:17:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30F2F61406 for ; Tue, 5 Oct 2021 01:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231202AbhJEBTq (ORCPT ); Mon, 4 Oct 2021 21:19:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230432AbhJEBTm (ORCPT ); Mon, 4 Oct 2021 21:19:42 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BF03C061749 for ; Mon, 4 Oct 2021 18:17:52 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id s24so24035297oij.8 for ; Mon, 04 Oct 2021 18:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DyHwOCOA8BVm3fIYmBKTBAquJnq6mmMC7RLAt62EphM=; b=j+McTh5xfKHvrsJdmlG/yhTupZ+rcdzKeHReBzcH/jlLl72oa1rOvM00PCQWPaVdYC 22ECc8DMmYf7ZlrCGWGnmIpgW32iKqfbiL6qfO36V02wstCKYAEyFe1ZgDvVxkYOA9ZX Y2m+6bhS0klquWQRUC50h15O86r7fipHYxmrJP/7mT6Lz7/IolgDCX9jTX10842uDgPQ QJutAmWSRoZ6Zjgx4NT0hmZxnR73+PqKgIgcw/u6yMe5yKz5zbRDVLI19bItUwCBptBn iHKEiHYMPd6EyUaoDDEa9gPiB3dKx96Nh7ue9kGfvDGRuvz2X5wWQTCYXsRAWgdpayHa +VWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DyHwOCOA8BVm3fIYmBKTBAquJnq6mmMC7RLAt62EphM=; b=KPdHmejh03XCI0nHtL43ijlVmrhf17afvWubhX4+H5j6d9OH+4mzsWU5JdZJHQ3JQP SM1QHmyAFoROpQnOr6+3xYlvuWDt9J6sJssTDSUlkjc0ftRNmnyYRYiW6HErzZTB4D1e IhKATKftbmMFwWc+rFzce0vyQpux5eIPjeZAuqc0wv0/KxKmHV/Fk7cnvwlppdVYzMvO gZAOdXirSYYNhZ60FdY2EKf86uS2OI8exlZUkJHocYTYwLKwf0IGOX9vgbAq944buXvq wj5F9UnhZBjdqe26eAq4zTA3vbTcUWgNBdD4Qf3YO5ugTztQMbkcd2uf5xg71FvUVuGm 0tAg== X-Gm-Message-State: AOAM533WTwjK/TUosI7P5TBMWCKr8itEwuErOBFg4mUteSny7rmo7j4A l065aiIhm00L38PuxPikAz+BnYeZ+UQfPQ== X-Google-Smtp-Source: ABdhPJwmQ7OVkAOxHeWgbzi4LvP7Fh8PsrcgGBo70cF0RyffToZ8fe55VvlWng17Yi5qBj2+JaHZIw== X-Received: by 2002:a05:6808:2128:: with SMTP id r40mr279140oiw.24.1633396671777; Mon, 04 Oct 2021 18:17:51 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id z10sm3263522otq.64.2021.10.04.18.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 18:17:51 -0700 (PDT) Date: Mon, 4 Oct 2021 18:19:34 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Abhinav Kumar , Daniel Vetter , David Airlie , Rob Clark , Rob Herring , Sean Paul , Kuogee Hsieh , Tanmay Shah , Chandan Uddaraju , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] drm/msm/dp: Refactor ioremap wrapper Message-ID: References: <20211001174400.981707-1-bjorn.andersson@linaro.org> <20211001174400.981707-4-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 04 Oct 18:04 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-01 10:43:58) > > In order to deal with multiple memory ranges in the following commit > > change the ioremap wrapper to not poke directly into the dss_io_data > > struct. > > > > While at it, devm_ioremap_resource() already prints useful error > > messages on failure, so omit the unnecessary prints from the caller. > > > > Signed-off-by: Bjorn Andersson > > --- > > Reviewed-by: Stephen Boyd > > I realize this will cause some prints when we use old DTs. I suppose > that's OK though because we'll have more incentive to update existing > DT. The use of the current binding is fairly limited, so I think that makes sense. Abhinav also requested earlier that we do that and drop the fallback sooner rather than later, which I would like to see as well. Thanks, Bjorn