From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78AF3C433EF for ; Wed, 6 Oct 2021 00:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BBAC60F92 for ; Wed, 6 Oct 2021 00:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237119AbhJFBB2 (ORCPT ); Tue, 5 Oct 2021 21:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236953AbhJFBB1 (ORCPT ); Tue, 5 Oct 2021 21:01:27 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC515C06174E for ; Tue, 5 Oct 2021 17:59:35 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 059BE581; Wed, 6 Oct 2021 02:59:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1633481973; bh=l+rjQCwGSyO9yFVWNn3k5VoiRZiXyt/OvwCdmBBkbIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=paeRZwqyBlSZYkzgJ9sRpDHvCCejFY33YXZ973CdSOdB9Lcdu7JHDfVOiLXezm/ZM Q073WIMbnCkoVtsQwmhgPz1FFbvhnpGUDbyxMjpBmetbphhwlwcAp0U3ou3pK5RSQz TJfxjOypdDXomdcFr/KAa28rCEIzOxlsDUhvpNss= Date: Wed, 6 Oct 2021 03:59:25 +0300 From: Laurent Pinchart To: Doug Anderson Cc: Rob Clark , dri-devel , freedreno , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Subject: Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support Message-ID: References: <20210920225801.227211-1-robdclark@gmail.com> <20210920225801.227211-4-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On Fri, Oct 01, 2021 at 11:02:54AM -0700, Doug Anderson wrote: > On Thu, Sep 23, 2021 at 7:26 PM Laurent Pinchart wrote: > > > > > > > err_conn_init: > > > > > drm_dp_aux_unregister(&pdata->aux); > > > > > return ret; > > > > > @@ -792,9 +790,30 @@ static void ti_sn_bridge_set_dsi_rate(struct ti_sn65dsi86 *pdata) > > > > > regmap_write(pdata->regmap, SN_DSIA_CLK_FREQ_REG, val); > > > > > } > > > > > > > > > > +/* > > > > > + * Find the connector and fish out the bpc from display_info. It would > > > > > + * be nice if we could get this instead from drm_bridge_state, but that > > > > > + * doesn't yet appear to be the case. > > > > > > > > You already have a bus format in the bridge state, from which you can > > > > derive the bpp. Could you give it a try ? > > > > > > Possibly the bridge should be converted to ->atomic_enable(), etc.. > > > I'll leave that for another time > > > > It should be fairly straightforward, and would avoid the hack below. > > Given this point of controversy, my inclination is to wait and not > apply this patch now. I don't think there's anything urgent here, > right? Worst case eventually Laurent might pick it up in his patch > series? At least we know it will work with the MSM driver once patch > #1 lands. :-) I've recorded the task for my upcoming work on the ti-sn65dsi86 driver. -- Regards, Laurent Pinchart