From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3C0C433FE for ; Mon, 18 Oct 2021 14:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 510B96128A for ; Mon, 18 Oct 2021 14:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbhJROhl (ORCPT ); Mon, 18 Oct 2021 10:37:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:56342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231495AbhJROhh (ORCPT ); Mon, 18 Oct 2021 10:37:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 469E060F93; Mon, 18 Oct 2021 14:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634567726; bh=KInWsI4wuwlzjBz/5eE+01JEOq1xYNH9oLLv8t2jPIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AFEZBNqNwFVvpuz1B/JJezzTujUyfCsQ0Zk02SR5yJhmORODj2U0jqnnRE5YeAUdR kQyzeocfAHaT6cl2x9IlM0MSgjZvT7+B/uXQWyXyjaF2qyJOSm5Xs9W5MsssvBnQn4 tJPPerNcXjys3ij1WHC1HtijhSyJiArWpO8BWZeQ= Date: Mon, 18 Oct 2021 16:35:24 +0200 From: Greg Kroah-Hartman To: Jarkko Sakkinen Cc: Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , reinette.chatre@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org Subject: Re: [PATCH v8 2/2] x86/sgx: Add an attribute for the amount of SGX memory in a NUMA node Message-ID: References: <20211018135744.45527-1-jarkko@kernel.org> <20211018135744.45527-2-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211018135744.45527-2-jarkko@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 04:57:44PM +0300, Jarkko Sakkinen wrote: > The amount of SGX memory on the system is determined by the BIOS and it > varies wildly between systems. It can be from dozens of MB's on desktops > or VM's, up to many GB's on servers. Just like for regular memory, it is > sometimes useful to know the amount of usable SGX memory in the system. > > Add an attribute for the amount of SGX memory in bytes to each NUMA > node. The path is /sys/devices/system/node/node[0-9]*/sgx/size. > Calculate these values by summing up EPC section sizes for each node > during the driver initalization. > > Cc: Greg Kroah-Hartman > Signed-off-by: Jarkko Sakkinen > --- > v8: > * Fix a bug in sgx_numa_init(): node->dev should be only set after > sysfe_create_group(). Otherwise, sysfs_remove_group() will issue a > warning in sgx_numa_exit(), when sgx_create_group() is unsuccessful, > because the group does not exist. > > v7: > * Shorten memory_size to size. The prefix makes the name only longer > but does not clarify things more than "size" would. > * Use device_attribute instead of kobj_attribute. > * Use named attribute group instead of creating raw kobject just for > the "sgx" subdirectory. > > v6: > * Initialize node->size to zero in sgx_setup_epc_section(), when the > node is first accessed. > > v5 > * A new patch based on the discussion on > https://lore.kernel.org/linux-sgx/3a7cab4115b4f902f3509ad8652e616b91703e1d.camel@kernel.org/T/#t > --- > Documentation/ABI/stable/sysfs-devices-node | 7 ++ > arch/x86/kernel/cpu/sgx/main.c | 85 +++++++++++++++++++++ > arch/x86/kernel/cpu/sgx/sgx.h | 2 + > 3 files changed, 94 insertions(+) > > diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node > index 484fc04bcc25..12dc2149e8e0 100644 > --- a/Documentation/ABI/stable/sysfs-devices-node > +++ b/Documentation/ABI/stable/sysfs-devices-node > @@ -176,3 +176,10 @@ Contact: Keith Busch > Description: > The cache write policy: 0 for write-back, 1 for write-through, > other or unknown. > + > +What: /sys/devices/system/node/nodeX/sgx/size > +Date: October 2021 > +Contact: Jarkko Sakkinen > +Description: > + Total available physical SGX memory, also known as Enclave Page > + Cache (EPC), in bytes. > diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/main.c > index a6e313f1a82d..dc1d46c51323 100644 > --- a/arch/x86/kernel/cpu/sgx/main.c > +++ b/arch/x86/kernel/cpu/sgx/main.c > @@ -714,9 +714,11 @@ static bool __init sgx_page_cache_init(void) > spin_lock_init(&sgx_numa_nodes[nid].lock); > INIT_LIST_HEAD(&sgx_numa_nodes[nid].free_page_list); > node_set(nid, sgx_numa_mask); > + sgx_numa_nodes[nid].size = 0; > } > > sgx_epc_sections[i].node = &sgx_numa_nodes[nid]; > + sgx_numa_nodes[nid].size += size; > > sgx_nr_epc_sections++; > } > @@ -790,6 +792,81 @@ int sgx_set_attribute(unsigned long *allowed_attributes, > } > EXPORT_SYMBOL_GPL(sgx_set_attribute); > > +#ifdef CONFIG_NUMA > +static ssize_t size_show(struct device *dev, struct device_attribute *attr, char *buf) > +{ > + unsigned long size = 0; > + int nid; > + > + for (nid = 0; nid < num_possible_nodes(); nid++) { > + if (dev == sgx_numa_nodes[nid].dev) { > + size = sgx_numa_nodes[nid].size; > + break; > + } > + } > + > + return sysfs_emit(buf, "%lu\n", size); > +} > +DEVICE_ATTR_RO(size); > + > +static struct attribute *sgx_node_attrs[] = { > + &dev_attr_size.attr, > + NULL, > +}; > + > +static const struct attribute_group sgx_node_attr_group = { > + .name = "sgx", > + .attrs = sgx_node_attrs, > +}; > + > +static void sgx_numa_exit(void) > +{ > + struct device *dev; > + int nid; > + > + for (nid = 0; nid < num_possible_nodes(); nid++) { > + dev = &node_devices[nid]->dev; > + if (dev) > + sysfs_remove_group(&dev->kobj, &sgx_node_attr_group); > + } > +} > + > +static bool sgx_numa_init(void) > +{ > + struct sgx_numa_node *node; > + struct device *dev; > + int nid; > + int ret; > + > + for (nid = 0; nid < num_possible_nodes(); nid++) { > + if (!sgx_numa_nodes[nid].size) > + continue; > + > + node = &sgx_numa_nodes[nid]; > + dev = &node_devices[nid]->dev; > + > + ret = sysfs_create_group(&dev->kobj, &sgx_node_attr_group); A huge hint, if a driver has to call a sysfs_* call, something is wrong. Something is wrong here. Why are you messing around with a kobject? This is a device, that you control, you can just set the default attribute group for it and then the driver core will add and remove the sysfs group at the proper time, in the proper way. Right now you are racing userspace and loosing. Use the default group list, that is what it is there for. thanks, greg k-h