From: Ansuel Smith <ansuelsmth@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net PATCH 1/2] drivers: net: phy: at803x: fix resume for QCA8327 phy
Date: Sat, 9 Oct 2021 01:50:21 +0200 [thread overview]
Message-ID: <YWDZPfWOe+C2abWz@Ansuel-xps.localdomain> (raw)
In-Reply-To: <20211008164750.4007f2d9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Oct 08, 2021 at 04:47:50PM -0700, Jakub Kicinski wrote:
> On Sat, 9 Oct 2021 01:34:25 +0200 Ansuel Smith wrote:
> > From Documentation phy resume triggers phy reset and restart
> > auto-negotiation. Add a dedicated function to wait reset to finish as
> > it was notice a regression where port sometime are not reliable after a
> > suspend/resume session. The reset wait logic is copied from phy_poll_reset.
> > Add dedicated suspend function to use genphy_suspend only with QCA8337
> > phy and set only additional debug settings for QCA8327. With more test
> > it was reported that QCA8327 doesn't proprely support this mode and
> > using this cause the unreliability of the switch ports, especially the
> > malfunction of the port0.
> >
> > Fixes: 15b9df4ece17 ("net: phy: at803x: add resume/suspend function to qca83xx phy")
>
> Hm, there's some confusion here. This commit does not exist in net,
> and neither does the one from patch 2.
>
> We should be fine with these going into net-next, right Andrew?
Took the hash from linux-next. Think this is the reason they are not in
net?
--
Ansuel
next prev parent reply other threads:[~2021-10-08 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 23:34 [net PATCH 1/2] drivers: net: phy: at803x: fix resume for QCA8327 phy Ansuel Smith
2021-10-08 23:34 ` [net PATCH 2/2] drivers: net: phy: at803x: add DAC amplitude fix for 8327 phy Ansuel Smith
2021-10-08 23:47 ` [net PATCH 1/2] drivers: net: phy: at803x: fix resume for QCA8327 phy Jakub Kicinski
2021-10-08 23:50 ` Ansuel Smith [this message]
2021-10-09 0:13 ` Jakub Kicinski
2021-10-09 0:16 ` Ansuel Smith
2021-10-09 14:58 ` Andrew Lunn
2021-10-09 15:01 ` Ansuel Smith
2021-10-09 15:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWDZPfWOe+C2abWz@Ansuel-xps.localdomain \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).